Skip to content

Conversation

@jansimonb
Copy link
Contributor

@jansimonb jansimonb commented May 22, 2025

Proposed Changes

Support fast writes without waiting for WAL persistence:

  • New write option (WriteOptions.noSync) added: true value means faster write but without the confirmation that
    the data was persisted. Default value: false.
  • Supported by self-managed InfluxDB 3 Core and Enterprise servers only!
  • Also configurable via connection string query parameter (writeNoSync).
  • Also configurable via environment variable (INFLUX_WRITE_NO_SYNC).
  • Long precision string values added from v3 HTTP API: "nanosecond", "microsecond", "millisecond", "second" (in addition to the existing "ns", "us", "ms", "s").

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov
Copy link

codecov bot commented May 26, 2025

Codecov Report

Attention: Patch coverage is 87.87879% with 8 lines in your changes missing coverage. Please review.

Project coverage is 90.10%. Comparing base (069e805) to head (8cb49f5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...luxdb/v3/client/write/WritePrecisionConverter.java 66.66% 2 Missing and 2 partials ⚠️
...ava/com/influxdb/v3/client/write/WriteOptions.java 89.47% 0 Missing and 2 partials ⚠️
...va/com/influxdb/v3/client/config/ClientConfig.java 92.30% 0 Missing and 1 partial ⚠️
...nfluxdb/v3/client/internal/InfluxDBClientImpl.java 95.45% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
- Coverage   90.19%   90.10%   -0.09%     
==========================================
  Files          19       20       +1     
  Lines        1142     1193      +51     
  Branches      178      187       +9     
==========================================
+ Hits         1030     1075      +45     
  Misses         41       41              
- Partials       71       77       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jansimonb jansimonb marked this pull request as ready for review May 26, 2025 09:44
Copy link
Contributor

@karel-rehor karel-rehor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests all pass locally. Changes make sense. 🚴 🏁

@jansimonb jansimonb merged commit 1f1ac3f into main Jun 3, 2025
8 of 9 checks passed
@jansimonb jansimonb deleted the feat/no-sync-write branch June 3, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants