BUG: Fix remotes maintenance scripts#1021
Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom Jun 17, 2019
Merged
BUG: Fix remotes maintenance scripts#1021dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
Conversation
Fix remotes maintenance scripts: - Fix scripts input arguments `command not found` error adding the `test` command over each argument.Fixes: ``` ./Utilities/Maintenance/ApplyScriptToRemotes.sh: line 82: UpdateTestingMacrosNames: command not found ./Utilities/Maintenance/ApplyScriptToRemotes.sh: line 82: ENH: Update ITK testing macros names: command not found ``` and idem for `UpdateRequiredITKVersionInRemoteModules.sh`. Avoid the script continuing its execution if not all input parameters have been provided. - Fix the `git add` command failing when not finding any file extension that matches the filters. This was causing that even files whose extension matched any of those before the missing one were not being added. Fixes: ``` fatal: pathspec './*.c' did not match any files fatal: pathspec './*.rst' did not match any files ``` Filters are now applied individually so that if one is not found/fails, the rest can still be added. Also, `stdout` and `stderr` are redirected to `/dev/null` to avoid excessive, additional verbosity. - Fix the commit message not being correctly processed: quotes within the script were missing (in addition to the quotes in the input argument so that the script considers it as a single argument). Fixes: ``` error: pathspec 'Update' did not match any file(s) known to git. error: pathspec 'ITK' did not match any file(s) known to git. error: pathspec 'testing' did not match any file(s) known to git. error: pathspec 'macros' did not match any file(s) known to git. error: pathspec 'names' did not match any file(s) known to git. ``` - Fix the `ITK-build` directory not being removed for being non empty. Fixes: ``` rm: cannot remove '../../../ITK-build': Directory not empty ```
jhlegarreta
added
type:Bug
jhlegarreta
requested review from
dzenanz,
fbudin69500,
hjmjohnson,
maekclena and
thewtex
Member
Author
|
Related to the remote module update effort required by #999 . |
dzenanz
approved these changes
Jun 14, 2019
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix remotes maintenance scripts:
command not founderror adding thetestcommand over each argument.Fixes:
and idem for
UpdateRequiredITKVersionInRemoteModules.sh.Avoid the script continuing its execution if not all input parameters have
been provided.
Fix the
git addcommand failing when not finding any file extensionthat matches the filters. This was causing that even files whose
extension matched any of those before the missing one were not being
added. Fixes:
Filters are now applied individually so that if one is not
found/fails, the rest can still be added. Also,
stdoutandstderrare redirected to
/dev/nullto avoid excessive, additionalverbosity.
Fix the commit message not being correctly processed: quotes within
the script were missing (in addition to the quotes in the input
argument so that the script considers it as a single argument).
Fixes:
Fix the
ITK-builddirectory not being removed for being non empty.Fixes:
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.