Skip to content

STYLE: Add ITK prefix to testing macros#999

Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom
maekclena:test_macros
Jun 6, 2019
Merged

STYLE: Add ITK prefix to testing macros#999
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom
maekclena:test_macros

Conversation

@maekclena
Copy link
Copy Markdown
Contributor

Closes #940.

Copy link
Copy Markdown
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on consistency!

@hjmjohnson hjmjohnson merged commit dbb1532 into InsightSoftwareConsortium:master Jun 6, 2019
@dzenanz
Copy link
Copy Markdown
Member

dzenanz commented Jun 10, 2019

This rename now needs to be done in remote modules too, e.g. C:\Dev\ITK-git\Modules\Remote\Thickness3D\test\itkBinaryThinningImageFilter3DTest.cxx(48,3): error C3861: 'TRY_EXPECT_NO_EXCEPTION': identifier not found

jhlegarreta added a commit to jhlegarreta/ITKSoftwareGuide that referenced this pull request Jun 11, 2019
Update ITK testing macros names after they were renamed in
InsightSoftwareConsortium/ITK#999
jhlegarreta added a commit to jhlegarreta/ITK that referenced this pull request Jun 11, 2019
Add script to update ITK testing macros names.

Motivated by PR InsightSoftwareConsortium#999.

This script should ease the task to update the testing macros names in
remote modules when used together with the
[ApplyScriptToRemotes.sh](https://github.com/InsightSoftwareConsortium/ITK/blob/master/Utilities/Maintenance/ApplyScriptToRemotes.sh)
script.
@jhlegarreta
Copy link
Copy Markdown
Member

A few remotes were updated applying the fixes in #1021 and executing:

./Utilities/Maintenance/ApplyScriptToRemotes.sh
~/src/itk/itk-head/ITK/Utilities/Maintenance/UpdateTestingMacrosNames.sh 
UpdateTestingMacrosNames "STYLE: Add ITK prefix to testing macros"

A few other issues arose (#1024 and #1025) while testing the script. Note that only remotes whose build status is successful are update.

Thanks for your patience.

@jhlegarreta
Copy link
Copy Markdown
Member

jhlegarreta commented Jun 15, 2019

Just for the sake of completeness, updated remote modules were

So it looks like quite a few have an unsuccessful build status currently.

hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request May 6, 2026
Add script to update ITK testing macros names.

Motivated by PR InsightSoftwareConsortium#999.

This script should ease the task to update the testing macros names in
remote modules when used together with the
[ApplyScriptToRemotes.sh](https://github.com/InsightSoftwareConsortium/ITK/blob/master/Utilities/Maintenance/ApplyScriptToRemotes.sh)
script.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ITK Testing Macros should be prefixed with ITK_

4 participants