Skip to content

BUG: Missing ImageAdapter function signatures#1207

Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom
hjmjohnson:fix-missing-func-signature-TransformLocalToPhysical
Aug 28, 2019
Merged

BUG: Missing ImageAdapter function signatures#1207
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom
hjmjohnson:fix-missing-func-signature-TransformLocalToPhysical

Conversation

@hjmjohnson
Copy link
Copy Markdown
Member

Missing function signatures were identified when
compiling GenericLabelInterpolationTestDriver.

@hjmjohnson hjmjohnson self-assigned this Aug 27, 2019
@hjmjohnson hjmjohnson requested a review from thewtex August 27, 2019 20:15
Comment thread Modules/Core/ImageAdaptors/test/itkVectorImageTest.cxx
@thewtex
Copy link
Copy Markdown
Member

thewtex commented Aug 27, 2019

itkVectorImage test fails with:

Testing Get/SetPixel methods.
Testing Get/SetPixel methods [PASSED]
Testing Graft method [PASSED]
Allocating an image of itk::VariableLengthVector of length 6 with image size [50, 50, 50] took 0.0166638 s.
ConstIterator Get() over the entire image took : 0.0172013 s.
Allocating an image of itk::FixedArray of length 6 with image size [50, 50, 50] took 0.000458002 s.
ConstIterator Get() over the entire image took : 0.000399947 s.
Allocating an image of itk::VectorImage with pixels length 6 with image size [50, 50, 50] took 0.00068903 s.
ConstIterator Get() over the entire vectorImage took : 0.000501037 s.
---------------------------------------------------------------
Testing N3itk25VectorImageToImageAdaptorIfLj3EEE to extract a component from the vector image
Before adaptor initialization, vectorImage->GetPixel([10, 10, 10])[4] = 4
[PASSED]
[FAILED]  TransformLocalVectorToPhysicalVector failed
[FAILED]  TransformPhysicalVectorToLocalVector failed
ImageRegionConstIteratorWithIndex on VectorImageAdaptor [PASSED]
---------------------------------------------------------------
Testing N3itk22NthElementImageAdaptorINS_11VectorImageIfLj3EEEfEE to extract a component from the vector image
Before adaptor initialization, vectorImage->GetPixel([10, 10, 10])[4] = 4
[PASSED]
[FAILED]  TransformLocalVectorToPhysicalVector failed
[FAILED]  TransformPhysicalVectorToLocalVector failed
ImageRegionConstIteratorWithIndex on VectorImageAdaptor [PASSED]
ImageRegionConstIteratorTest on VectorImage [PASSED]
ImageLinearConstIteratorWithIndex on VectorImage [PASSED]
ImageLinearIteratorWithIndex on VectorImage [PASSED]
Read VectorImage [PASSED]
Write VectorImage [PASSED]
Testing ConstNeighborhoodIterator....
Testing NeighborhoodIterator...
Testing ConstShapedNeighborhoodIterator on VectorImage...
0 1 2 3 4 5 6 7 8 13 

@hjmjohnson hjmjohnson force-pushed the fix-missing-func-signature-TransformLocalToPhysical branch 2 times, most recently from c7f717e to 20f162e Compare August 27, 2019 22:14
@hjmjohnson
Copy link
Copy Markdown
Member Author

@thewtex

itkVectorImage test fails with:

Huh? It does not fail on my computer.

The following tests passed:
	itkVectorImageReadWriteTest
	itkVectorImageReadWriteTest2
	itkVectorImageTest
	itkVectorImageToImageAdaptorTest

100% tests passed, 0 tests failed out of 4

I what computer platform is failing for you?

@thewtex
Copy link
Copy Markdown
Member

thewtex commented Aug 27, 2019

I what computer platform is failing for you?

Looking at the CI result.

Missing function signatures were identified when
compiling GenericLabelInterpolationTestDriver.
@hjmjohnson hjmjohnson force-pushed the fix-missing-func-signature-TransformLocalToPhysical branch from 20f162e to 8ffeda6 Compare August 28, 2019 02:20
@hjmjohnson hjmjohnson merged commit 55f8ac2 into InsightSoftwareConsortium:master Aug 28, 2019
@hjmjohnson hjmjohnson deleted the fix-missing-func-signature-TransformLocalToPhysical branch October 23, 2019 13:31
N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Nov 21, 2021
Added the four missing single parameter overloads of point/index/vector
conversion member functions to `ImageAdaptor`, which were already there
for `ImageBase` with ITK version 5.0:

    TransformPhysicalPointToIndex
    TransformPhysicalPointToContinuousIndex
    TransformContinuousIndexToPhysicalPoint
    TransformIndexToPhysicalPoint

Included a GoogleTest unit test.

Follow-up to pull request InsightSoftwareConsortium#868
commit 65233e3
"ENH: Convenience overloads for ImageBase Transform member functions"

And pull request InsightSoftwareConsortium#1207
commit 55f8ac2
"BUG: Missing ImageAdapter function signatures"
N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Nov 21, 2021
Added the four missing single parameter overloads of point/index/vector
conversion member functions to `ImageAdaptor`, which were already there
for `ImageBase` with ITK version 5.0:

    TransformPhysicalPointToIndex
    TransformPhysicalPointToContinuousIndex
    TransformContinuousIndexToPhysicalPoint
    TransformIndexToPhysicalPoint

Included a GoogleTest unit test.

Follow-up to pull request InsightSoftwareConsortium#868
commit 65233e3
"ENH: Convenience overloads for ImageBase Transform member functions"

And pull request InsightSoftwareConsortium#1207
commit 55f8ac2
"BUG: Missing ImageAdapter function signatures"
N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Nov 21, 2021
Added the four missing single parameter overloads of point/index/vector
conversion member functions to `ImageAdaptor`, which were already there
for `ImageBase` with ITK version 5.0:

    TransformPhysicalPointToIndex
    TransformPhysicalPointToContinuousIndex
    TransformContinuousIndexToPhysicalPoint
    TransformIndexToPhysicalPoint

Included a GoogleTest unit test.

Follow-up to pull request InsightSoftwareConsortium#868
commit 65233e3
"ENH: Convenience overloads for ImageBase Transform member functions"

And pull request InsightSoftwareConsortium#1207
commit 55f8ac2
"BUG: Missing ImageAdapter function signatures"
dzenanz pushed a commit that referenced this pull request Nov 23, 2021
Added the four missing single parameter overloads of point/index/vector
conversion member functions to `ImageAdaptor`, which were already there
for `ImageBase` with ITK version 5.0:

    TransformPhysicalPointToIndex
    TransformPhysicalPointToContinuousIndex
    TransformContinuousIndexToPhysicalPoint
    TransformIndexToPhysicalPoint

Included a GoogleTest unit test.

Follow-up to pull request #868
commit 65233e3
"ENH: Convenience overloads for ImageBase Transform member functions"

And pull request #1207
commit 55f8ac2
"BUG: Missing ImageAdapter function signatures"
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request May 6, 2026
Added the four missing single parameter overloads of point/index/vector
conversion member functions to `ImageAdaptor`, which were already there
for `ImageBase` with ITK version 5.0:

    TransformPhysicalPointToIndex
    TransformPhysicalPointToContinuousIndex
    TransformContinuousIndexToPhysicalPoint
    TransformIndexToPhysicalPoint

Included a GoogleTest unit test.

Follow-up to pull request InsightSoftwareConsortium#868
commit 0669b74
"ENH: Convenience overloads for ImageBase Transform member functions"

And pull request InsightSoftwareConsortium#1207
commit 31bfd18
"BUG: Missing ImageAdapter function signatures"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants