BUG: Add missing single argument ImageAdaptor Transform member functions#2889
Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom Nov 23, 2021
Conversation
github-actions
Bot
added
area:Core
N-Dekker
force-pushed
the
ImageAdaptor-single-parameter-conversion-functions
branch
5 times, most recently
from
a798cf8 to
810d2ea
Compare
Added the four missing single parameter overloads of point/index/vector
conversion member functions to `ImageAdaptor`, which were already there
for `ImageBase` with ITK version 5.0:
TransformPhysicalPointToIndex
TransformPhysicalPointToContinuousIndex
TransformContinuousIndexToPhysicalPoint
TransformIndexToPhysicalPoint
Included a GoogleTest unit test.
Follow-up to pull request InsightSoftwareConsortium#868
commit 65233e3
"ENH: Convenience overloads for ImageBase Transform member functions"
And pull request InsightSoftwareConsortium#1207
commit 55f8ac2
"BUG: Missing ImageAdapter function signatures"
N-Dekker
force-pushed
the
ImageAdaptor-single-parameter-conversion-functions
branch
from
810d2ea to
5fa53b4
Compare
dzenanz
approved these changes
Nov 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the four missing single parameter overloads of point/index/vector
conversion member functions to
ImageAdaptor, which were already therefor
ImageBasewith ITK version 5.0:Included a GoogleTest unit test.
Follow-up to pull request #868
commit 65233e3
"ENH: Convenience overloads for ImageBase Transform member functions" (by me)
And pull request #1207
commit 55f8ac2
"BUG: Missing ImageAdapter function signatures" by Hans Johnson (@hjmjohnson)