ENH: Avoid duplicated code in itk::HistogramThresholdImageFilter#1732
Merged
jhlegarreta merged 1 commit intoInsightSoftwareConsortium:masterfrom Mar 28, 2020
Conversation
jhlegarreta
requested review from
blowekamp,
dzenanz,
hjmjohnson,
richardbeare and
thewtex
jhlegarreta
added
area:Filtering
dzenanz
approved these changes
Mar 27, 2020
Member
|
Modules/Filtering/Thresholding/include/itkHistogramThresholdImageFilter.hxx:77:83: error: typename specifier refers to non-type member 'New' in 'itk::Statistics::ImageToHistogramFilter<itk::Image<float, 2> >' |
Refactor `itk::HistogramThresholdImageFilter` to avoid duplicated code, and thus prevent potential bugs that can go unnoticed.
jhlegarreta
force-pushed
the
AvoidDuplicateCodeInHistogramThresholdImageFilter
branch
from
9f03b21 to
4217cc0
Compare
dzenanz
approved these changes
Mar 27, 2020
jhlegarreta
deleted the
AvoidDuplicateCodeInHistogramThresholdImageFilter
branch
This was referenced Mar 29, 2020
hjmjohnson
pushed a commit
to hjmjohnson/ITK
that referenced
this pull request
May 6, 2026
…oidDuplicateCodeInHistogramThresholdImageFilter ENH: Avoid duplicated code in `itk::HistogramThresholdImageFilter`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
itk::HistogramThresholdImageFilterto avoid duplicated code,and thus prevent potential bugs that can go unnoticed.
PR Checklist