ENH: Make the histogram generator set up method private#1734
Merged
jhlegarreta merged 1 commit intoInsightSoftwareConsortium:masterfrom Mar 30, 2020
Conversation
jhlegarreta
added
type:Enhancement
jhlegarreta
requested review from
blowekamp,
dzenanz,
hjmjohnson,
richardbeare and
thewtex
jhlegarreta
changed the title
jhlegarreta
force-pushed
the
MakeHistogramGeneratorSetUpMethodPrivate
branch
from
23938f7 to
6322100
Compare
dzenanz
approved these changes
Mar 29, 2020
Member
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
This method was introduced a few days ago, right?
Make the `itk::HistogramThresholdImageFilter::SetUpHistogramGenerator` method introduced in commit 4217cc0 be `private`: no child classes should be able to call the method since it is an essential step in the parent's `GenerateData` method.
jhlegarreta
force-pushed
the
MakeHistogramGeneratorSetUpMethodPrivate
branch
from
6322100 to
8f8b7ca
Compare
Member
Author
Yes, less than a day ago: That's why I marked that the PR does not involve changing the API. |
hjmjohnson
pushed a commit
to hjmjohnson/ITK
that referenced
this pull request
May 6, 2026
…keHistogramGeneratorSetUpMethodPrivate ENH: Make the histogram generator set up method private
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the
itk::HistogramThresholdImageFilter::SetUpHistogramGeneratormethod introduced in commit 4217cc0 be
private: no child classes shouldbe able to call the method since it is an essential step in the parent's
GenerateDatamethod.PR Checklist