ENH: Add convenience function ReadImage#2184
Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom Dec 22, 2020
Merged
ENH: Add convenience function ReadImage#2184hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom
Conversation
Contributor
Author
|
Review suggestion: ignore white space when comparing the files: https://github.com/InsightSoftwareConsortium/ITK/pull/2184/files?w=1 |
Member
|
Nice! LGTM, but I think @dzenanz should have a look before merging. |
Contributor
Author
|
@hjmjohnson Thank you for your approval, Hans. An alternative could be to add the function as a That would also be OK to me. But I think people prefer to just call |
dzenanz
approved these changes
Dec 17, 2020
Member
|
@thewtex we should definitely mention these convenience functions in 5.2.0 release notes. |
blowekamp
previously requested changes
Dec 18, 2020
Member
blowekamp
left a comment
blowekamp
left a comment
There was a problem hiding this comment.
The behavior to the streaming test changes with this PR.
N-Dekker
force-pushed
the
Add-convenience-function-ReadImage
branch
2 times, most recently
from
e1a671a to
56f39bb
Compare
Added `itk::ReadImage<TOutputImage>(const std::string & filename)`, to allows simplifying the C++ code for reading an image. Suggested by Dženan Zukić at InsightSoftwareConsortium#2102 (comment) Follow-up to: "ENH: add a convenience function WriteImage" Pull request: InsightSoftwareConsortium#2160 Commit: 60b0984 Replaced manual creation of `ImageFileReader` objects in Common tests by calls to the new `itk::ReadImage` function. Also removed related redundant try-catch blocks from SymmetricSecondRankTensorImage tests.
N-Dekker
force-pushed
the
Add-convenience-function-ReadImage
branch
from
56f39bb to
3778f98
Compare
dzenanz
approved these changes
Dec 21, 2020
dzenanz
dismissed
blowekamp’s stale review
Requested change has been addressed
Member
Good question @dzenanz but honestly I do not know. The function template is entirely implemented "header only" (implemented entiry in the .h file) so I thought an export macro wouldn't be necessary. What would the macro do? |
N-Dekker
added a commit
to N-Dekker/ITK
that referenced
this pull request
Dec 22, 2020
Tests that an image written by `itk::WriteImage` can be read back, without loss of data. Uses two recently added functions: - `itk::ReadImage`: pull request InsightSoftwareConsortium#2184 commit aeea88b - `operator==` for images: pull request InsightSoftwareConsortium#2188 commit 7f3337d (`operator==` is called internally by GoogleTest `EXPECT_EQ`.)
hjmjohnson
pushed a commit
that referenced
this pull request
Dec 22, 2020
Tests that an image written by `itk::WriteImage` can be read back, without loss of data. Uses two recently added functions: - `itk::ReadImage`: pull request #2184 commit aeea88b - `operator==` for images: pull request #2188 commit 7f3337d (`operator==` is called internally by GoogleTest `EXPECT_EQ`.)
7 tasks
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
May 5, 2022
Follow-up to ITK pull request InsightSoftwareConsortium/ITK#2184 commit InsightSoftwareConsortium/ITK@aeea88b "ENH: Add convenience function ReadImage", merged on on 22 December 2020, and included with ITK v5.2rc01.
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
May 5, 2022
Follow-up to ITK pull request InsightSoftwareConsortium/ITK#2184 commit InsightSoftwareConsortium/ITK@aeea88b "ENH: Add convenience function ReadImage", merged on on 22 December 2020, and included with ITK v5.2rc01.
N-Dekker
added a commit
to SuperElastix/elastix
that referenced
this pull request
May 5, 2022
Follow-up to ITK pull request InsightSoftwareConsortium/ITK#2184 commit InsightSoftwareConsortium/ITK@aeea88b "ENH: Add convenience function ReadImage", merged on on 22 December 2020, and included with ITK v5.2rc01.
N-Dekker
added a commit
to N-Dekker/ITKSphinxExamples
that referenced
this pull request
May 16, 2022
Follow-up to ITK pull request InsightSoftwareConsortium/ITK#2184 commit InsightSoftwareConsortium/ITK@aeea88b "ENH: Add convenience function ReadImage", merged on 22 December 2020, and included with ITK v5.2rc01
dzenanz
pushed a commit
to InsightSoftwareConsortium/ITKSphinxExamples
that referenced
this pull request
May 17, 2022
Follow-up to ITK pull request InsightSoftwareConsortium/ITK#2184 commit InsightSoftwareConsortium/ITK@aeea88b "ENH: Add convenience function ReadImage", merged on 22 December 2020, and included with ITK v5.2rc01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
itk::ReadImage<TOutputImage>(const std::string & filename), toallows simplifying the C++ code for reading an image.
Suggested by Dženan Zukić (@dzenanz) at
#2102 (comment)
Follow-up to:
"ENH: add a convenience function WriteImage"
Pull request: #2160
Commit: 60b0984
Replaced manual creation of
ImageFileReaderobjects in Common tests bycalls to the new
itk::ReadImagefunction. Also removed relatedredundant try-catch blocks from SymmetricSecondRankTensorImage tests.