ENH: Extend ITKWriteImageFunctionTest by reading the written image back#2203
Merged
hjmjohnson merged 1 commit intoInsightSoftwareConsortium:masterfrom Dec 22, 2020
Conversation
Tests that an image written by `itk::WriteImage` can be read back, without loss of data. Uses two recently added functions: - `itk::ReadImage`: pull request InsightSoftwareConsortium#2184 commit aeea88b - `operator==` for images: pull request InsightSoftwareConsortium#2188 commit 7f3337d (`operator==` is called internally by GoogleTest `EXPECT_EQ`.)
Contributor
Author
|
Extended Bradley's unit test to check WYWIWYR: What You Write Is What You Read 😸 |
dzenanz
approved these changes
Dec 22, 2020
blowekamp
approved these changes
Dec 22, 2020
Member
blowekamp
left a comment
blowekamp
left a comment
There was a problem hiding this comment.
Looks nice.
Just an FYI: The MHA headers encode some of the meta data number as text. The reading and writing cycle can be lossy for non-trivial values.
Contributor
Author
@blowekamp Thanks for reminding me that this image ==> |
hjmjohnson
approved these changes
Dec 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests that an image written by
itk::WriteImagecan be read back,without loss of data.
Uses two recently added functions:
itk::ReadImage: pull request ENH: Add convenience function ReadImage #2184 commit aeea88boperator==for images: pull request ENH: Add operator== and operator!= to itk::Image #2188 commit 7f3337d(
operator==is called internally by GoogleTestEXPECT_EQ.)