STYLE: Avoid repeating parent aliases in operator classes by jhlegarreta · Pull Request #2567 · InsightSoftwareConsortium/ITK

jhlegarreta · 2021-06-02T02:23:57Z

Avoid repeating parent aliases in Common operator classes.

PR Checklist

No API changes were made (or the changes have been approved)
No major design changes were made (or the changes have been approved)

hjmjohnson

This is a good start. Please cherry-pick the last two commits from https://github.com/hjmjohnson/ITK/tree/AvoidRepeatingParentAliasesInCommonOperators. does a more complete refactoring to keep the style and recommendations consistent.

Avoid repeating parent aliases in `Common` operator classes whenever possible. Use the preferred `using typename Superclass::{TypeAlias}` aliasing form for the relevant type. Make the `CoefficientVector` type be public in `itk::NeighborhoodOperator` so that child classes can have access to it.

Following ITK pull request InsightSoftwareConsortium/ITK#2567 "STYLE: Avoid repeating parent aliases..." commit InsightSoftwareConsortium/ITK@babece9 and InsightSoftwareConsortium/ITK@4f30980 Using Visual Studio 2019 Find and Replace regular expressions: typedef typename Superclass::(\w+)[ ]+\1; using typename Superclass::$1;

Following ITK pull request InsightSoftwareConsortium/ITK#2567 "STYLE: Avoid repeating parent aliases..." commit InsightSoftwareConsortium/ITK@babece9 and InsightSoftwareConsortium/ITK@4f30980 Using Visual Studio 2019 Find and Replace regular expressions, like: typedef typename Superclass::(\w+)[ ]+\1; using typename Superclass::$1;

Following ITK pull request InsightSoftwareConsortium/ITK#2567 "STYLE: Avoid repeating parent aliases..." commit InsightSoftwareConsortium/ITK@babece9 and InsightSoftwareConsortium/ITK@4f30980 Using Visual Studio 2019 Find and Replace regular expressions, like: typedef Superclass::(\w+)[ ]+\1; using Superclass::$1;

Following ITK pull request InsightSoftwareConsortium/ITK#2567 "STYLE: Avoid repeating parent aliases..." commit InsightSoftwareConsortium/ITK@babece9 and InsightSoftwareConsortium/ITK@4f30980 Using Visual Studio 2019 Find and Replace regular expressions, like: typedef typename Superclass::(\w+)[ ]+\1; using typename Superclass::$1;

jhlegarreta · 2021-09-22T13:19:39Z

The CDash builds are not happy with this change 😟.

As for the failure in itkMultiphaseDenseFiniteDifferenceImageFilterTest.cxx, I think the superclass alias is missing the last template parameter ( TIdCell) here. Which seems to be a bug that surfaced thanks to the PR at least 🛠️.

I will submit a patch set for it later today.

The rest of the failures to the reported 50 require more investigation.

dzenanz · 2021-09-22T13:30:12Z

Oh, I just now see this. That's what happens when there are 30 new emails in the morning 😄

jhlegarreta · 2021-09-23T13:45:34Z

@hjmjohnson I had a quick look yesterday to the rest of the compilation errors, but was not able to come up with a solution. Can you please have a look? Thanks.

dzenanz · 2021-09-23T13:52:20Z

@seanm just submitted #2753.

jhlegarreta · 2021-09-23T13:59:04Z

@seanm just submitted #2753.

The fix for one of the files has already been merged in #2751. I missed the other file. Sorry and thanks @seanm.

Not sure why the conflict with the master branch has not triggered.

@dzenanz Unfortunately, the rest of the failures to the listed 50 dwell in some other files.

seanm · 2021-09-23T14:03:16Z

I've just rebased #2753.

Does the github-based CI have Module_ITKReview enabled anywhere? I'm guessing not... it probably should...

jhlegarreta · 2021-09-23T14:11:12Z

I've just rebased #2753.

👍

Does the github-based CI have Module_ITKReview enabled anywhere? I'm guessing not... it probably should...

Yep, I agree. I think it has been brought a few times before, e.g. #2653 (comment). But maybe there are reasons that are unknown to me that make enabling the Review module for the CI builds not paying off.

dzenanz · 2021-09-23T15:37:32Z

Review module is fairly small now. I think we can enable it for the CI. PR incoming.

Following ITK pull request InsightSoftwareConsortium/ITK#2567 "STYLE: Avoid repeating parent aliases..." commit InsightSoftwareConsortium/ITK@babece9 and InsightSoftwareConsortium/ITK@4f30980 Using Visual Studio 2019 Find and Replace regular expressions, like: typedef typename Superclass::(\w+)[ ]+\1; using typename Superclass::$1;

Partially reverted pull request InsightSoftwareConsortium#2567 commit 4f30980 "STYLE: Avoid repeating parent aliases" because of Visual Studio 2017 compile errors reported by Dženan Zukić at InsightSoftwareConsortium#2759 "COMP: making it compile on VS2017" Worked around the following VS2017 compile errors: > error C2653: '...': is not a class or namespace name > error C2886: '...': symbol cannot be used in a member using-declaration The compiler bug that caused these errors is reported here: "Compile error when using "using declaration" referencing a base class type that refers to itself" EssentiaX - Reported March 12, 2019 [Fixed in version 16.2] https://developercommunity.visualstudio.com/t/486683

Partially reverted pull request #2567 commit 4f30980 "STYLE: Avoid repeating parent aliases" because of Visual Studio 2017 compile errors reported by Dženan Zukić at #2759 "COMP: making it compile on VS2017" Worked around the following VS2017 compile errors: > error C2653: '...': is not a class or namespace name > error C2886: '...': symbol cannot be used in a member using-declaration The compiler bug that caused these errors is reported here: "Compile error when using "using declaration" referencing a base class type that refers to itself" EssentiaX - Reported March 12, 2019 [Fixed in version 16.2] https://developercommunity.visualstudio.com/t/486683

Partially reverted pull request InsightSoftwareConsortium#2567 commit 77006be "STYLE: Avoid repeating parent aliases" because of Visual Studio 2017 compile errors reported by Dženan Zukić at InsightSoftwareConsortium#2759 "COMP: making it compile on VS2017" Worked around the following VS2017 compile errors: > error C2653: '...': is not a class or namespace name > error C2886: '...': symbol cannot be used in a member using-declaration The compiler bug that caused these errors is reported here: "Compile error when using "using declaration" referencing a base class type that refers to itself" EssentiaX - Reported March 12, 2019 [Fixed in version 16.2] https://developercommunity.visualstudio.com/t/486683

jhlegarreta mentioned this pull request Jun 2, 2021

STYLE: Prefer aliasing template pixel type in common operator classes #2561

Closed

2 tasks

github-actions Bot added area:Core Issues affecting the Core module type:Style Style changes: no logic impact (indentation, comments, naming) labels Jun 2, 2021

jhlegarreta requested review from Leengit, N-Dekker, blowekamp, dzenanz, hjmjohnson and thewtex June 2, 2021 02:26

jhlegarreta force-pushed the AvoidRepeatingParentAliasesInCommonOperators branch 3 times, most recently from 08a6e45 to 830c693 Compare June 2, 2021 03:42

dzenanz approved these changes Jun 2, 2021

View reviewed changes

Comment thread Modules/Core/Common/include/itkNeighborhoodOperator.h Outdated

dzenanz reviewed Jun 2, 2021

View reviewed changes

Comment thread Modules/Core/Common/include/itkNeighborhoodOperator.h Outdated

dzenanz reviewed Jun 2, 2021

View reviewed changes

Comment thread Modules/Core/Common/include/itkGaussianDerivativeOperator.h

jhlegarreta force-pushed the AvoidRepeatingParentAliasesInCommonOperators branch 4 times, most recently from cfcf52b to cfa8825 Compare June 2, 2021 23:14

dzenanz reviewed Jun 2, 2021

View reviewed changes

Comment thread Modules/Core/Common/include/itkDerivativeOperator.h Outdated

jhlegarreta force-pushed the AvoidRepeatingParentAliasesInCommonOperators branch 3 times, most recently from 45217ee to abe65f2 Compare June 2, 2021 23:45

hjmjohnson previously requested changes Jun 3, 2021

View reviewed changes

jhlegarreta force-pushed the AvoidRepeatingParentAliasesInCommonOperators branch from abe65f2 to 201537c Compare September 11, 2021 23:45

github-actions Bot added area:Examples Demonstration of the use of classes area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module area:Numerics Issues affecting the Numerics module labels Sep 11, 2021

jhlegarreta force-pushed the AvoidRepeatingParentAliasesInCommonOperators branch from 201537c to 0069817 Compare September 18, 2021 15:58

dzenanz approved these changes Sep 20, 2021

View reviewed changes

dzenanz merged commit e64795c into InsightSoftwareConsortium:master Sep 21, 2021

jhlegarreta deleted the AvoidRepeatingParentAliasesInCommonOperators branch September 21, 2021 13:37

jhlegarreta mentioned this pull request Sep 22, 2021

BUG: Provide missing template parameter to superclass #2751

Merged

2 tasks

N-Dekker mentioned this pull request Sep 24, 2021

Replace typedefs from base-classes by using-declarations, fix related bugs SuperElastix/elastix#527

Merged

jhlegarreta mentioned this pull request Sep 24, 2021

COMP: Fix missing initialization braces warning #2756

Merged

2 tasks

N-Dekker mentioned this pull request Oct 3, 2021

COMP: making it compile on VS2017 #2759

Closed

N-Dekker mentioned this pull request Oct 5, 2021

Workaround VS2017 compile errors using-declarations #2780

Merged

N-Dekker mentioned this pull request Jan 3, 2023

COMP: Fix MSVC error C2516: 'ConstIterator': is not a legal base class #3844

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

STYLE: Avoid repeating parent aliases in operator classes#2567

STYLE: Avoid repeating parent aliases in operator classes#2567
dzenanz merged 3 commits intoInsightSoftwareConsortium:masterfrom
jhlegarreta:AvoidRepeatingParentAliasesInCommonOperators

jhlegarreta commented Jun 2, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hjmjohnson left a comment

Uh oh!

jhlegarreta commented Sep 22, 2021 •

edited

Loading

Uh oh!

dzenanz commented Sep 22, 2021

Uh oh!

jhlegarreta commented Sep 23, 2021

Uh oh!

dzenanz commented Sep 23, 2021

Uh oh!

jhlegarreta commented Sep 23, 2021 •

edited

Loading

Uh oh!

seanm commented Sep 23, 2021

Uh oh!

jhlegarreta commented Sep 23, 2021

Uh oh!

dzenanz commented Sep 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

jhlegarreta commented Jun 2, 2021

PR Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hjmjohnson left a comment

Choose a reason for hiding this comment

Uh oh!

jhlegarreta commented Sep 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dzenanz commented Sep 22, 2021

Uh oh!

jhlegarreta commented Sep 23, 2021

Uh oh!

dzenanz commented Sep 23, 2021

Uh oh!

jhlegarreta commented Sep 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

seanm commented Sep 23, 2021

Uh oh!

jhlegarreta commented Sep 23, 2021

Uh oh!

dzenanz commented Sep 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jhlegarreta commented Sep 22, 2021 •

edited

Loading

jhlegarreta commented Sep 23, 2021 •

edited

Loading