Skip to content

COMP: fixed compile errors due to incorrect superclass identification#2753

Merged
thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom
seanm:ReviewBuildErrors
Sep 23, 2021
Merged

COMP: fixed compile errors due to incorrect superclass identification#2753
thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom
seanm:ReviewBuildErrors

Conversation

@seanm
Copy link
Copy Markdown
Contributor

@seanm seanm commented Sep 23, 2021

PR Checklist

  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added Python wrapping to new files (if any) as described in ITK Software Guide Section 9.5
  • Added ITK examples for all new major features (if any)

Refer to the ITK Software Guide for
further development details if necessary.

@seanm
Copy link
Copy Markdown
Contributor Author

seanm commented Sep 23, 2021

@dzenanz @hjmjohnson @N-Dekker

How did these build errors sneak in? Does the github-based CI have itkReview enabled anywhere?

@github-actions github-actions Bot added type:Compiler Compiler support or related warnings type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct labels Sep 23, 2021
@jhlegarreta jhlegarreta self-requested a review September 23, 2021 15:39
Copy link
Copy Markdown
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @seanm !

@thewtex thewtex merged commit b301e5b into InsightSoftwareConsortium:master Sep 23, 2021
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request May 6, 2026
…ildErrors

COMP: fixed compile errors due to incorrect superclass identification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:Compiler Compiler support or related warnings type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants