Skip to content

COMP: Fix undeclared identifier error#2800

Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
jhlegarreta:Fix1DFFTImageFilterDirectionClampMacro
Oct 11, 2021
Merged

COMP: Fix undeclared identifier error#2800
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
jhlegarreta:Fix1DFFTImageFilterDirectionClampMacro

Conversation

@jhlegarreta
Copy link
Copy Markdown
Member

Fix undeclared identifier error.

Fixes:

In file included from
/Users/builder/externalModules/Filtering/FFT/test/itkComplexToComplex1DFFTImageFilterTest.cxx:27:
/Users/builder/externalModules/Filtering/FFT/include/itkComplexToComplex1DFFTImageFilter.h:84:48:
error: use of undeclared identifier 'ImageDimension'
  itkSetClampMacro(Direction, unsigned int, 0, ImageDimension - 1);
                                               ^

and

In file included from
/Users/builder/externalModules/Filtering/FFT/test/itkFFT1DImageFilterTest.cxx:25:
/Users/builder/externalModules/Filtering/FFT/include/itkForward1DFFTImageFilter.h:67:48:
error: use of undeclared identifier 'ImageDimension'
  itkSetClampMacro(Direction, unsigned int, 0, ImageDimension - 1);
                                               ^

and

In file included from
/Users/builder/externalModules/Filtering/FFT/test/itkInverse1DFFTImageFilterTest.cxx:26:
/Users/builder/externalModules/Filtering/FFT/include/itkInverse1DFFTImageFilter.h:68:48:
error: use of undeclared identifier 'ImageDimension'
  itkSetClampMacro(Direction, unsigned int, 0, ImageDimension - 1);
                                               ^

reported for example at:
https://open.cdash.org/viewBuildError.php?buildid=7505348

PR Checklist

Fix undeclared identifier error.

Fixes:
```
In file included from
/Users/builder/externalModules/Filtering/FFT/test/itkComplexToComplex1DFFTImageFilterTest.cxx:27:
/Users/builder/externalModules/Filtering/FFT/include/itkComplexToComplex1DFFTImageFilter.h:84:48:
error: use of undeclared identifier 'ImageDimension'
  itkSetClampMacro(Direction, unsigned int, 0, ImageDimension - 1);
                                               ^
```

and
```
In file included from
/Users/builder/externalModules/Filtering/FFT/test/itkFFT1DImageFilterTest.cxx:25:
/Users/builder/externalModules/Filtering/FFT/include/itkForward1DFFTImageFilter.h:67:48:
error: use of undeclared identifier 'ImageDimension'
  itkSetClampMacro(Direction, unsigned int, 0, ImageDimension - 1);
                                               ^
```

and
```
In file included from
/Users/builder/externalModules/Filtering/FFT/test/itkInverse1DFFTImageFilterTest.cxx:26:
/Users/builder/externalModules/Filtering/FFT/include/itkInverse1DFFTImageFilter.h:68:48:
error: use of undeclared identifier 'ImageDimension'
  itkSetClampMacro(Direction, unsigned int, 0, ImageDimension - 1);
                                               ^
```

reported for example at:
https://open.cdash.org/viewBuildError.php?buildid=7505348
@jhlegarreta jhlegarreta requested a review from tbirdso October 11, 2021 15:10
@github-actions github-actions Bot added area:Filtering Issues affecting the Filtering module type:Compiler Compiler support or related warnings labels Oct 11, 2021
Copy link
Copy Markdown
Contributor

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. LGTM provided that CI passes.

1D FFT files were originally added to ITKUltrasound a few years ago and it looks like there are some "growing pains" from adding them to ITK proper. Thanks again for resolving issues where they arise.

Copy link
Copy Markdown
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhlegarreta thank you!!

@dzenanz dzenanz merged commit 94dfea4 into InsightSoftwareConsortium:master Oct 11, 2021
@jhlegarreta jhlegarreta deleted the Fix1DFFTImageFilterDirectionClampMacro branch October 11, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Filtering Issues affecting the Filtering module type:Compiler Compiler support or related warnings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants