COMP: Fix undeclared identifier error#2800
Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom Oct 11, 2021
Merged
Conversation
Fix undeclared identifier error.
Fixes:
```
In file included from
/Users/builder/externalModules/Filtering/FFT/test/itkComplexToComplex1DFFTImageFilterTest.cxx:27:
/Users/builder/externalModules/Filtering/FFT/include/itkComplexToComplex1DFFTImageFilter.h:84:48:
error: use of undeclared identifier 'ImageDimension'
itkSetClampMacro(Direction, unsigned int, 0, ImageDimension - 1);
^
```
and
```
In file included from
/Users/builder/externalModules/Filtering/FFT/test/itkFFT1DImageFilterTest.cxx:25:
/Users/builder/externalModules/Filtering/FFT/include/itkForward1DFFTImageFilter.h:67:48:
error: use of undeclared identifier 'ImageDimension'
itkSetClampMacro(Direction, unsigned int, 0, ImageDimension - 1);
^
```
and
```
In file included from
/Users/builder/externalModules/Filtering/FFT/test/itkInverse1DFFTImageFilterTest.cxx:26:
/Users/builder/externalModules/Filtering/FFT/include/itkInverse1DFFTImageFilter.h:68:48:
error: use of undeclared identifier 'ImageDimension'
itkSetClampMacro(Direction, unsigned int, 0, ImageDimension - 1);
^
```
reported for example at:
https://open.cdash.org/viewBuildError.php?buildid=7505348
tbirdso
approved these changes
Oct 11, 2021
Contributor
tbirdso
left a comment
There was a problem hiding this comment.
Good catch. LGTM provided that CI passes.
1D FFT files were originally added to ITKUltrasound a few years ago and it looks like there are some "growing pains" from adding them to ITK proper. Thanks again for resolving issues where they arise.
dzenanz
approved these changes
Oct 11, 2021
This was referenced Oct 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix undeclared identifier error.
Fixes:
and
and
reported for example at:
https://open.cdash.org/viewBuildError.php?buildid=7505348
PR Checklist