COMP: Replace itkStaticConstMacro with constexpr in 1D FFT classes

[tbirdso]

Resolves Nightly Build errors at https://open.cdash.org/viewBuildError.php?buildid=7507611

PR Checklist

• No API changes were made (or the changes have been approved)
• No major design changes were made (or the changes have been approved)

Refer to the ITK Software Guide for
further development details if necessary.

[jhlegarreta]

👍 for doing this.

#2800 can then be reverted I guess. My fault for not having solved the root problem.

Also, these are errors rather than warnings.

[N-Dekker]

Off-topic but slightly related: I see two itkGetMacro calls in these files. As far as I know, itkGetConstMacro would be preferred.

[jhlegarreta]

Off-topic but slightly related: I see two itkGetMacro calls in these files. As far as I know, itkGetConstMacro would be preferred.

That should clearly go in a separate PR; if I'm not mistaken it changes the API and should go into a deprecation cycle.

[seanm]

FYI, I run the RogueResearch submissions. If y'all could try to remember to CC me, it would save duplicate work of me chasing things now then finding hours later this PR exists already. :)

[dzenanz]

I guess we are subscribed to all news in ITK repository. I kind of assumed the other active members (including you @seanm) are "watching" it too.

[seanm]

I guess we are subscribed to all news in ITK repository.

I'm not, but I'll try turning that on. Sounds like it might be an intense firehose though...

[dzenanz]

If the thread ends in "@x merged #Y", you can archive the conversation without reading through. But having the notifications allows you to not miss the action.

[dzenanz]

You can always reduce your watching level to "mentions only", if full watching is overwhelming. The upcoming weeks are likely to have more traffic than usual, due to proximity of a release.

[seanm]

You can always reduce your watching level to "mentions only",

That's what I was set to until just now, but no one @mentioned me on this PR, which was my point. :) But now I'm on 'All Activity', will see how that goes...

[jhlegarreta]

That's what I was set to until just now, but no one @mentioned me on this PR, which was my point. :) But now I'm on 'All Activity', will see how that goes...

I take the blame on this @seanm. I should have tagged you for the previous related PRs that I started and that motivated this one. Sorry.

[seanm]

I take the blame on this @seanm. I should have tagged you for the previous related PRs that I started and that motivated this one. Sorry.

Oh it's no biggie! Was just a suggestion for next time.

[thewtex]

👍

[thewtex]

Thanks, all, for hunting these down!