Skip to content

STYLE: Use the itkNameOfTestExecutableMacro macro in tests#2985

Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
jhlegarreta:UseITKNameOfTestExecutableMacro2
Dec 27, 2021
Merged

STYLE: Use the itkNameOfTestExecutableMacro macro in tests#2985
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
jhlegarreta:UseITKNameOfTestExecutableMacro2

Conversation

@jhlegarreta
Copy link
Copy Markdown
Member

@jhlegarreta jhlegarreta commented Dec 22, 2021

Use the itkNameOfTestExecutableMacro macro to get the test name
instead of hard-coding the test name.

PR Checklist

@jhlegarreta jhlegarreta force-pushed the UseITKNameOfTestExecutableMacro2 branch from 1abe5da to e012193 Compare December 22, 2021 01:13
@github-actions github-actions Bot added area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module area:Registration Issues affecting the Registration module type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Style Style changes: no logic impact (indentation, comments, naming) type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct labels Dec 22, 2021
@jhlegarreta
Copy link
Copy Markdown
Member Author

jhlegarreta commented Dec 22, 2021

Left behind in PR #2939.

A couple of additional notes:

  • Not sure if this is the right move for itkCMakeConfigurationTest, as it does not depend on ITK. Insights are welcome.
  • Some of the changes (added the Missing parameters message, changing std::cout to std::cerr) were only made in cases where the whole check was changed in order to restrict the number of changes to what it made sense as the necessary minimum. Making the style of the checking consistent beyond these can be done in a separate PR.

@jhlegarreta jhlegarreta force-pushed the UseITKNameOfTestExecutableMacro2 branch from e012193 to 1f2c50f Compare December 22, 2021 01:18
dzenanz
dzenanz approved these changes Dec 22, 2021
View reviewed changes
Comment thread Modules/Core/Common/test/itkCMakeConfigurationTest.cxx
thewtex
thewtex approved these changes Dec 22, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💚

@jhlegarreta
STYLE: Use the itkNameOfTestExecutableMacro macro in tests
a7a4a0e 
Use the `itkNameOfTestExecutableMacro` macro to get the test name
instead of hard-coding the test name.
@jhlegarreta jhlegarreta force-pushed the UseITKNameOfTestExecutableMacro2 branch from 1f2c50f to a7a4a0e Compare December 23, 2021 22:15
@github-actions github-actions Bot added the area:Video Issues affecting the Video module label Dec 23, 2021
@jhlegarreta
Copy link
Copy Markdown
Member Author

jhlegarreta commented Dec 24, 2021

/azp run ITK.macOS

@jhlegarreta
Copy link
Copy Markdown
Member Author

jhlegarreta commented Dec 24, 2021

/azp run ITK.macOS.Python

@dzenanz dzenanz merged commit 706ff72 into InsightSoftwareConsortium:master Dec 27, 2021
@jhlegarreta jhlegarreta deleted the UseITKNameOfTestExecutableMacro2 branch December 27, 2021 19:17
@jhlegarreta jhlegarreta mentioned this pull request Jan 8, 2022
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dzenanz dzenanz dzenanz approved these changes

@thewtex thewtex thewtex approved these changes

Assignees

No one assigned

Labels

area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module area:Registration Issues affecting the Registration module area:Video Issues affecting the Video module type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Style Style changes: no logic impact (indentation, comments, naming) type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jhlegarreta @thewtex @dzenanz