STYLE: Use the itkNameOfTestExecutableMacro macro in tests#3064
Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom Jan 11, 2022
Merged
Conversation
Member
Author
|
Left behind in earlier related PRs, e.g. #2985. |
github-actions
Bot
added
area:Filtering
jhlegarreta
force-pushed
the
UseITKNameOfTestExecutableMacro3
branch
4 times, most recently
from
2157ab3 to
a299f73
Compare
Use the `itkNameOfTestExecutableMacro` macro to get the test name instead of hard-coding the test name. Avoid directly passing the test's main method `argc` and `argv` parameters to helper methods: provide only the required parameters. Fix the argument count check where necessary, and prefer using exact checks when no optional argument exists.
jhlegarreta
force-pushed
the
UseITKNameOfTestExecutableMacro3
branch
from
a299f73 to
debf968
Compare
thewtex
approved these changes
Jan 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the
itkNameOfTestExecutableMacromacro to get the test nameinstead of hard-coding the test name.
Avoid directly passing the test's main method
argcandargvparameters to helper methods: provide only the required parameters.
Fix the argument count check where necessary, and prefer using exact
checks when no optional argument exists.
PR Checklist