COMP: Fix typo (compile error) in PhilipsRECImageIO constructor#3668
Merged
N-Dekker merged 1 commit intoInsightSoftwareConsortium:masterfrom Sep 28, 2022
Merged
Conversation
dzenanz
approved these changes
Sep 28, 2022
Member
|
Preferably merge today. |
Contributor
Author
@dzenanz Do you think we should still wait for the CI? It did not notice the typo in the first place, as Module_ITKIOPhilipsREC is off by default. |
Member
|
CI doesn't seem to be running. Could you force-push to try to re-trigger it? I would prefer for CI to finish, at least cxx tests. Python packaging takes longer, and if you need to go to sleep before it finishes, merge 😄 |
Fixed a compile error, which appeared when enabling `Module_ITKIOPhilipsREC`: > itkPhilipsRECImageIO.cxx(390,3): error C3861: 'iff': identifier not found This obvious typo was introduced with pull request InsightSoftwareConsortium#3664 commit 2b1b531 "STYLE: Remove space between class and member names (follow-up)", and reported by Bradley Lowekamp.
N-Dekker
force-pushed
the
Fix-typo-PhilipsRECImageIO-iff
branch
from
7931f20 to
f8fda8a
Compare
github-actions
Bot
added
area:IO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a compile error, which appeared when enabling
Module_ITKIOPhilipsREC:This obvious typo was introduced with pull request #3664 commit 2b1b531 "STYLE: Remove space between class and member names (follow-up)", and reported by Bradley Lowekamp (@blowekamp).