Skip to content

STYLE: Remove space between class and member names (follow-up)#3664

Merged
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
N-Dekker:Remove-space-between-IO-class-and-member-names
Sep 27, 2022
Merged

STYLE: Remove space between class and member names (follow-up)#3664
dzenanz merged 1 commit intoInsightSoftwareConsortium:masterfrom
N-Dekker:Remove-space-between-IO-class-and-member-names

Conversation

@N-Dekker
Copy link
Copy Markdown
Contributor

@N-Dekker N-Dekker commented Sep 26, 2022 •
edited
Loading

Removed spaces between class and member names, that were
accidentally introduced with pull request #1191
commit 2074c2f "STYLE: Enforce ITK style
defined by .clang-format".

Using bash commands like:

find . \( -iname *.cxx \) -exec perl -pi -w -e 's/([A-Z]\w+) \:\:(\w)/$1::$2/g;' {} \;

Follow-up to pull request #2096
commit 734d6f8 "STYLE: Remove space between
class and member names in C++ source files"

@github-actions github-actions Bot added area:IO Issues affecting the IO module area:Video Issues affecting the Video module type:Style Style changes: no logic impact (indentation, comments, naming) labels Sep 26, 2022
@N-Dekker N-Dekker requested a review from hjmjohnson September 26, 2022 16:44
@N-Dekker
STYLE: Remove space between class and member names (follow-up)
1c9d360 
Removed spaces between class and member names, that were
accidentally introduced with pull request InsightSoftwareConsortium#1191
commit 2074c2f "STYLE: Enforce ITK style
defined by .clang-format".

Using bash commands like:

  find . \( -iname *.cxx \) -exec perl -pi -w -e 's/([A-Z]\w+) \:\:(\w)/$1::$2/g;' {} \;

Follow-up to pull request InsightSoftwareConsortium#2096
commit 734d6f8 "STYLE: Remove space between
class and member names in C++ source files"
@N-Dekker N-Dekker force-pushed the Remove-space-between-IO-class-and-member-names branch from 44452c1 to 1c9d360 Compare September 26, 2022 19:42
@github-actions github-actions Bot added area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:Numerics Issues affecting the Numerics module area:Segmentation Issues affecting the Segmentation module labels Sep 26, 2022
@N-Dekker N-Dekker changed the title STYLE: Replace space from IO :: in "itk*IO.cxx" files STYLE: Remove space between class and member names (follow-up) Sep 26, 2022
thewtex
thewtex approved these changes Sep 26, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@N-Dekker N-Dekker marked this pull request as ready for review September 27, 2022 10:06
@dzenanz dzenanz merged commit 2b1b531 into InsightSoftwareConsortium:master Sep 27, 2022
blowekamp
blowekamp reviewed Sep 28, 2022
View reviewed changes
Comment thread Modules/IO/PhilipsREC/src/itkPhilipsRECImageIO.cxx
// this will be changed if we're reading a file to whatever
// the file actually contains.
if (ByteSwapper<int>::SystemIsBigEndian())
iff(ByteSwapper<int>::SystemIsBigEndian())
Copy link
Copy Markdown
Member

@blowekamp blowekamp Sep 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@N-Dekker This line does not compile.

Copy link
Copy Markdown
Contributor Author

@N-Dekker N-Dekker Sep 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@blowekamp Thanks, I'll propose a fix!

Copy link
Copy Markdown
Contributor Author

@N-Dekker N-Dekker Sep 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First, I'll switch on Module_ITKIOPhilipsREC, to avoid introducing more silly mistakes!

N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Sep 28, 2022
@N-Dekker
COMP: Fix typo (compile error) in PhilipsRECImageIO constructor
072318a 
Fixed a compile error, which appeared when enabling `Module_ITKIOPhilipsREC`:

> itkPhilipsRECImageIO.cxx(390,3): error C3861: 'iff': identifier not found

This obvious typo was introduced with pull request InsightSoftwareConsortium#3664
commit 2b1b531 "STYLE: Remove space between
class and member names (follow-up)", and reported by Bradley Lowekamp.
N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Sep 28, 2022
@N-Dekker
COMP: Fix typo (compile error) in PhilipsRECImageIO constructor
7931f20 
Fixed a compile error, which appeared when enabling `Module_ITKIOPhilipsREC`:

> itkPhilipsRECImageIO.cxx(390,3): error C3861: 'iff': identifier not found

This obvious typo was introduced with pull request InsightSoftwareConsortium#3664
commit 2b1b531 "STYLE: Remove space between
class and member names (follow-up)", and reported by Bradley Lowekamp.
@N-Dekker N-Dekker mentioned this pull request Sep 28, 2022
Merged
N-Dekker added a commit to N-Dekker/ITK that referenced this pull request Sep 28, 2022
@N-Dekker
COMP: Fix typo (compile error) in PhilipsRECImageIO constructor
f8fda8a 
Fixed a compile error, which appeared when enabling `Module_ITKIOPhilipsREC`:

> itkPhilipsRECImageIO.cxx(390,3): error C3861: 'iff': identifier not found

This obvious typo was introduced with pull request InsightSoftwareConsortium#3664
commit 2b1b531 "STYLE: Remove space between
class and member names (follow-up)", and reported by Bradley Lowekamp.
N-Dekker added a commit that referenced this pull request Sep 28, 2022
@N-Dekker
COMP: Fix typo (compile error) in PhilipsRECImageIO constructor
8ad7354 
Fixed a compile error, which appeared when enabling `Module_ITKIOPhilipsREC`:

> itkPhilipsRECImageIO.cxx(390,3): error C3861: 'iff': identifier not found

This obvious typo was introduced with pull request #3664
commit 2b1b531 "STYLE: Remove space between
class and member names (follow-up)", and reported by Bradley Lowekamp.
@jhlegarreta jhlegarreta mentioned this pull request Jul 18, 2023
Closed
@jhlegarreta jhlegarreta mentioned this pull request Jan 20, 2025
Closed
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request May 6, 2026
@N-Dekker
COMP: Fix typo (compile error) in PhilipsRECImageIO constructor
cab3cf5 
Fixed a compile error, which appeared when enabling `Module_ITKIOPhilipsREC`:

> itkPhilipsRECImageIO.cxx(390,3): error C3861: 'iff': identifier not found

This obvious typo was introduced with pull request InsightSoftwareConsortium#3664
commit 18e63a4 "STYLE: Remove space between
class and member names (follow-up)", and reported by Bradley Lowekamp.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blowekamp blowekamp blowekamp left review comments

@thewtex thewtex thewtex approved these changes

@dzenanz dzenanz dzenanz approved these changes

@hjmjohnson hjmjohnson Awaiting requested review from hjmjohnson

Assignees

No one assigned

Labels

area:Core Issues affecting the Core module area:Filtering Issues affecting the Filtering module area:IO Issues affecting the IO module area:Numerics Issues affecting the Numerics module area:Segmentation Issues affecting the Segmentation module area:Video Issues affecting the Video module type:Style Style changes: no logic impact (indentation, comments, naming)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@N-Dekker @thewtex @blowekamp @dzenanz