BUG: DCMTK reader wrongly rejects file with preamble#4110
BUG: DCMTK reader wrongly rejects file with preamble#4110pieper wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
Conversation
A previous optimization didn't take into account the premable of a dicom file. This adds a check. Fixes InsightSoftwareConsortium#4801
|
@hjmjohnson could you have a look at this? It fixes #4108 |
|
I confirm that DCMTKIO's DCMTKImageIO::CanReadFile function returns false for valid DICOM files with preamble. I have reproduced it just now. |
|
Thanks for doing this @pieper. I am willing to give this a 👍 when the following are addressed:
In general, commits should only fall into one category, |
|
Thanks for the review @jhlegarreta - I had tried to add just the one function but it looks like my checkout was against an older target. I'll fix it. |
|
@pieper did you have time to address Jon's feedback? |
| @@ -230,7 +259,7 @@ DCMTKImageIO::CanReadFile(const char * filename) | |||
| } | |||
There was a problem hiding this comment.
This could be removed following seek to 0
|
#4501 has updates with @jhlegarreta requests addressed (note that |
|
Superceded by #4501 |
A previous optimization didn't take into account the premable of a dicom file. This adds a check.
Fixes #4108