COMP: Add GDCM system version check for SetSecondaryCaptureImagePlaneModule#4601
Merged
thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom Apr 21, 2024
Merged
Conversation
github-actions
Bot
added
type:Compiler
Member
Author
|
Verified with system GDCM on Debian Bullseye. |
Member
|
Thank you! BTW, there is another call on line 284 (in 'Debug' mode). |
…Module This has not been released in GDCM, yet. Avoid build errors for a system GDCM. There will be a difference in behavior, which will be flagged with failing tests. Co-authored-by: Mihail Isakov <mihail.isakov@gmail.com>
thewtex
force-pushed
the
gdcm-version-check
branch
from
06a4dce to
f4e9b0b
Compare
issakomi
approved these changes
Apr 20, 2024
issakomi
added a commit
to issakomi/ITK
that referenced
this pull request
Apr 24, 2024
…aneModule Follow up InsightSoftwareConsortium#4601 GDCM master has currenlty 3.1.0. Updated check to include versions 3.1+.
issakomi
added a commit
to issakomi/ITK
that referenced
this pull request
Apr 24, 2024
…aneModule Follow up InsightSoftwareConsortium#4601 GDCM master is currently at version 3.1.0. Updated check to include versions 3.1+.
issakomi
added a commit
to issakomi/ITK
that referenced
this pull request
Apr 24, 2024
…aneModule Follow up InsightSoftwareConsortium#4601 GDCM master is currently at version 3.1.0. Updated check to include versions 3.1+.
bourdaisj
pushed a commit
to bourdaisj/ITK
that referenced
this pull request
May 15, 2024
…aneModule Follow up InsightSoftwareConsortium#4601 GDCM master is currently at version 3.1.0. Updated check to include versions 3.1+.
hjmjohnson
pushed a commit
to hjmjohnson/ITK
that referenced
this pull request
May 6, 2026
…ersion-check COMP: Add GDCM system version check for SetSecondaryCaptureImagePlaneModule
hjmjohnson
pushed a commit
to hjmjohnson/ITK
that referenced
this pull request
May 6, 2026
…aneModule Follow up InsightSoftwareConsortium#4601 GDCM master is currently at version 3.1.0. Updated check to include versions 3.1+.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has not been released in GDCM, yet. Avoid build errors for a system
GDCM. There will be a difference in behavior, which will be flagged with
failing tests.
Co-authored-by: Mihail Isakov mihail.isakov@gmail.com