COMP: Update GDCM system version check for SetSecondaryCaptureImagePlaneModule#4609
Merged
thewtex merged 1 commit intoInsightSoftwareConsortium:masterfrom Apr 24, 2024
Merged
Conversation
github-actions
Bot
added
type:Compiler
N-Dekker
reviewed
Apr 24, 2024
N-Dekker
reviewed
Apr 24, 2024
…aneModule Follow up InsightSoftwareConsortium#4601 GDCM master is currently at version 3.1.0. Updated check to include versions 3.1+.
thewtex
approved these changes
Apr 24, 2024
hjmjohnson
pushed a commit
to hjmjohnson/ITK
that referenced
this pull request
May 6, 2026
COMP: Update GDCM system version check for SetSecondaryCaptureImagePlaneModule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up #4601
GDCM master branch is currently at version 3.1.0.
Updated check to include versions 3.1+.
P.S.
Maybe GDCM will change its approach in the future and not insist on
SecondaryCaptureImagePlaneModule=truefor reading at all. ImagePlaneModule for SC is a part of the standard now. But it is still there. The variable could be useful for writing in the future.