Skip to content

Typographical, Grammatical, and Wording Suggestions for Software Guide Examples#6

Closed
sudomakeinstall wants to merge 10 commits intoInsightSoftwareConsortium:masterfrom
sudomakeinstall:master
Closed

Typographical, Grammatical, and Wording Suggestions for Software Guide Examples#6
sudomakeinstall wants to merge 10 commits intoInsightSoftwareConsortium:masterfrom
sudomakeinstall:master

Conversation

@sudomakeinstall
Copy link
Copy Markdown
Member

No description provided.

@iMichka
Copy link
Copy Markdown
Contributor

iMichka commented Feb 4, 2015

Hi. Thanks for the patch ! Documentation updates are always welcome.

We currently don't support github pull requests (but this is being worked on because it simplifies patch submissions). Could you provide submit your changes to our gerrit review system ?

The setup is fairly easy:
http://insightsoftwareconsortium.github.io/ITKBarCamp-doc/CommunitySoftwareProcess/SubmitAPatchToGerrit/index.html

Just a note; please provide the changes as a single commit. You will need to use the git rebase option to squash all the commits to a single one for the first submission.

@sudomakeinstall
Copy link
Copy Markdown
Member Author

Michka--

Apologies for this—shortly after submitting, I saw that there were no other push requests, and realized something must be amiss. I hadn’t come across the BarCamp videos you linked to. I will re-submit properly tomorrow.

Best, and thanks,

—Davis

On Feb 4, 2015, at 9:54 PM, Michka Popoff notifications@github.com wrote:

Hi. Thanks for the patch ! Documentation updates are always welcome.

We currently don't support github pull requests (but this is being worked on because it simplifies patch submissions). Could you provide submit your changes to our gerrit review system ?

The setup is fairly easy:
http://insightsoftwareconsortium.github.io/ITKBarCamp-doc/CommunitySoftwareProcess/SubmitAPatchToGerrit/index.html http://insightsoftwareconsortium.github.io/ITKBarCamp-doc/CommunitySoftwareProcess/SubmitAPatchToGerrit/index.html
Just a note; please provide the changes as a single commit. You will need to use the git rebase option to squash all the commits to a single one for the first submission.


Reply to this email directly or view it on GitHub #6 (comment).

@iMichka
Copy link
Copy Markdown
Contributor

iMichka commented Feb 4, 2015

Hi
no problem. Please add me to the reviewers list so I can review and merge the changes.
Could you also please close this Pull Request ?

Thanks

kwrobot referenced this pull request in Kitware/ITK Dec 16, 2016
…tion

Alexander Schmidt-Richberg (1):
      BUG: Small bugs fixed to avoid compiler warnings (unsigned int and unused variable).

Francois Budin (6):
      ENH: Replacing test data with MD5
      STYLE: Improve style to pass KWStyle test
      DOC: Missing backslash in documentation
      COMP: Remove compilation warnings from Visual Studio
      COMP: Correct warning due to locally defined symbol
      Merge pull request InsightSoftwareConsortium#9 from fbudin69500/locally_defined_symbol

aschmiri (5):
      Merge pull request #3 from thewtex/doxygen-warnings
      Merge pull request #4 from fbudin69500/DOC_missing_backslash_in_documentation
      Merge pull request #5 from fbudin69500/ENH_replace_test_data_with_MD5
      Merge pull request #6 from fbudin69500/ImproveStyle
      Merge pull request InsightSoftwareConsortium#7 from fbudin69500/remove_VS_warning_cherry_picked

Change-Id: Ibb959bc84e01edb6c3b78e0984d9f029992ff5af
HastingsGreer pushed a commit to HastingsGreer/ITK that referenced this pull request Feb 10, 2019
…perrors

COMP: fix compilation errors in SpatialObject and SpatialObjectProperty
fbordignon added a commit to fbordignon/ITK that referenced this pull request Jan 20, 2023
Hello, I was having trouble with an external python calling the itk function as shared below. The ?? sometimes indicates a callback but to be sure I searched all instances of H5VL_group_close and only H5G__close_cb was calling it and it is currently unmangled. I will test this soon and report back.

<details>

```
#0  0x00007febfdaa8b49 in itk_H5CX_get_vol_wrap_ctx () from /home/gabriel/g/bin/../lib/GeoSlicer-5.1/libitkhdf5-shared-5.3.so.1
InsightSoftwareConsortium#1  0x00007febfdd23a44 in itk_H5VL_set_vol_wrapper () from /home/gabriel/g/bin/../lib/GeoSlicer-5.1/libitkhdf5-shared-5.3.so.1
InsightSoftwareConsortium#2  0x00007febfdd1870b in itk_H5VL_group_close () from /home/gabriel/g/bin/../lib/GeoSlicer-5.1/libitkhdf5-shared-5.3.so.1
InsightSoftwareConsortium#3  0x00007febfdb4b11d in ?? () from /home/gabriel/g/bin/../lib/GeoSlicer-5.1/libitkhdf5-shared-5.3.so.1
InsightSoftwareConsortium#4  0x00007fead7b7d480 in H5I_dec_ref () from /home/gabriel/g/lib/Python/lib/python3.9/site-packages/h5py/../h5py.libs/libhdf5-346dbfc8.so.200.1.0
InsightSoftwareConsortium#5  0x00007fead7b7d544 in H5I_dec_app_ref () from /home/gabriel/g/lib/Python/lib/python3.9/site-packages/h5py/../h5py.libs/libhdf5-346dbfc8.so.200.1.0
InsightSoftwareConsortium#6  0x00007fead7b79fd1 in H5Idec_ref () from /home/gabriel/g/lib/Python/lib/python3.9/site-packages/h5py/../h5py.libs/libhdf5-346dbfc8.so.200.1.0
```
</details>
hjmjohnson pushed a commit that referenced this pull request Apr 25, 2026
hjmjohnson added a commit that referenced this pull request Apr 28, 2026
BUG: Fix KWStyle error for header guarderd in test
hjmjohnson pushed a commit that referenced this pull request Apr 30, 2026
BUG: Update Multithreader API calls
hjmjohnson pushed a commit that referenced this pull request May 5, 2026
COMP: Remove unused typedefs in the test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants