ENH: Cleanup python wrapping tests#643
Merged
fbudin69500 merged 2 commits intoInsightSoftwareConsortium:masterfrom Mar 30, 2019
maekclena:cleanup_python_test
Merged
ENH: Cleanup python wrapping tests#643fbudin69500 merged 2 commits intoInsightSoftwareConsortium:masterfrom maekclena:cleanup_python_test
fbudin69500 merged 2 commits intoInsightSoftwareConsortium:masterfrom
maekclena:cleanup_python_test
Conversation
dzenanz
approved these changes
Mar 28, 2019
Member
dzenanz
left a comment
dzenanz
left a comment
There was a problem hiding this comment.
Honestly, I don't know why [
ScanlineFilterCommon] needs to be wrapped.
Python wrapping complains if it is not wrapped? 😄
fbudin69500
reviewed
Mar 28, 2019
Contributor
fbudin69500
left a comment
fbudin69500
left a comment
There was a problem hiding this comment.
Thanks for cleaning up!
Contributor
|
Awesome! Thanks! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exclude-filters.txtfindEmptyClasses.pyScanlineFilterCommonfromgetNameOfClass.pyto fix Re-enable thePythonGetNameOfClasstest #96.I initially wanted to rewrite
ScanlineFilterCommonto have it inheritImageToImageFilterbut this introduces a diamond inheritance withInPlaceImageFilter, which I imagine is why is used composition in the first place. Honestly, I don't know why it needs to be wrapped.