[Python-builds] Cleanup python test#644
Closed
maekclena wants to merge 8 commits intoInsightSoftwareConsortium:python-buildsfrom
maekclena:cleanup_python_test
Closed
[Python-builds] Cleanup python test#644maekclena wants to merge 8 commits intoInsightSoftwareConsortium:python-buildsfrom maekclena:cleanup_python_test
maekclena wants to merge 8 commits intoInsightSoftwareConsortium:python-buildsfrom
maekclena:cleanup_python_test
Conversation
Simplified `ImageFileReader::GenerateData()` implementation by declaring its local `loadBuffer` as `const std::unique_ptr<char[]>`, instead of as a raw `char` pointer. Removed try-catch-throw and `delete[]` statements that are no longer necessary now, due to the C++ "RAII" idiom implemented by `std::unique_ptr`. Replaced a `std::copy` by `std::copy_n`, to further simplify the code.
Add a script to update the remote module commit hashes. Update the `Release.md` guide to add the remote module update step prior to a release.
Add a script to update the ITK tag as required in - `azure-pipelines.yaml` Azure pipelines configuration file. - `setup.py` Python setup files. usually in the `Remote` modules.
STYLE: ImageFileReader uses std::unique_ptr<[]>, try-catch-throw removed
ENH: Add a script to update the remote module commit hashes
ENH: Add a script to update the ITK tag as required in files
Contributor
|
Merged #643 into master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python builds for #643.
Sorry for the other commits, I rebased from master.