Skip to content

ENH: Add a script to update the ITK tag as required in files#641

Merged
jhlegarreta merged 1 commit intoInsightSoftwareConsortium:masterfrom
jhlegarreta:UpdateRequiredITKVersionInFiles
Mar 28, 2019
Merged

ENH: Add a script to update the ITK tag as required in files#641
jhlegarreta merged 1 commit intoInsightSoftwareConsortium:masterfrom
jhlegarreta:UpdateRequiredITKVersionInFiles

Conversation

@jhlegarreta
Copy link
Copy Markdown
Member

Add a script to update the ITK tag as required in

  • azure-pipelines.yaml Azure pipelines configuration file.
  • setup.py Python setup files.

usually in the Remote modules.

PR Checklist

Refer to the ITK Software Guide for
further development details if necessary.

@jhlegarreta jhlegarreta added type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Enhancement Improvement of existing methods or implementation labels Mar 28, 2019
@jhlegarreta
Copy link
Copy Markdown
Member Author

I guess that same remark from remote update applies here regarding relative path to Setup.py file.

@dzenanz I do agree that this would make things easier and cleaner.

That would require cloning each remote, may be using CMake to checkout them out. I usually do the editions to the remotes outside my ITK source tree, and I am not too familiar with dealing repositories or submodules inside another repository. I would need to investigate how they are cloned, whether cloning within the ITK folder creates a per-remote git history and corresponding branches, etc.

Also, the relative path solution assumes that all azure-pipelines.yml files are all in the same location. Although we will eventually get there, it is not the case yet.

I haven't got the bandwith to address the relative location improvement right now, so for now I will stick to the input arguments.

But at some point in time (i.e. not in the short term) I will investigate the above and propose the changes to the script. That should also facilitate using scripts that apply changes over all modules.

Add a script to update the ITK tag as required in
- `azure-pipelines.yaml` Azure pipelines configuration file.
- `setup.py` Python setup files.

usually in the `Remote` modules.
@jhlegarreta jhlegarreta force-pushed the UpdateRequiredITKVersionInFiles branch from 84407eb to e0fe885 Compare March 28, 2019 00:44
Copy link
Copy Markdown
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jhlegarreta jhlegarreta merged commit 9cde0e3 into InsightSoftwareConsortium:master Mar 28, 2019
@jhlegarreta jhlegarreta deleted the UpdateRequiredITKVersionInFiles branch March 28, 2019 03:16
hjmjohnson pushed a commit to hjmjohnson/ITK that referenced this pull request May 6, 2026
…ateRequiredITKVersionInFiles

ENH: Add a script to update the ITK tag as required in files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants