Skip to content

ENH: Add a script to update the ITK tag in Python setup.py files#633

Closed
jhlegarreta wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
jhlegarreta:AddPythonSetupITKTagUpdateScript
Closed

ENH: Add a script to update the ITK tag in Python setup.py files#633
jhlegarreta wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
jhlegarreta:AddPythonSetupITKTagUpdateScript

Conversation

@jhlegarreta
Copy link
Copy Markdown
Member

Add a script to update the ITK tag in Python setup.py files.

Add a script to update the ITK tag in Python `setup.py` files.
@jhlegarreta jhlegarreta added type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots area:Python wrapping Python bindings for a class type:Enhancement Improvement of existing methods or implementation labels Mar 25, 2019
@jhlegarreta
Copy link
Copy Markdown
Member Author

jhlegarreta commented Mar 25, 2019

A few comments:

  • This will surely need further testing.
  • jq must be available.
  • Assuming that the requirement field is not empty.
  • Assuming that no changes are made to the = or >= symbol (although we will want to change to the latter I guess).
  • Assuming all tags have the v prefix.
  • We may need to ask for the username so that the user is authenticated in the curl command. I think there is a limit in the anonymous gets.
  • I guess generating a branch and automatically committing/pushing as @hjmjohnson has done in some scripts is also doable, but this is a first version.

Copy link
Copy Markdown
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

Copy link
Copy Markdown
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Comment thread Utilities/Maintenance/UpdateITKGitTagPythonSetup.sh
@jhlegarreta
Copy link
Copy Markdown
Member Author

Superseded by #641 for the reasons stated in #634.

@jhlegarreta jhlegarreta deleted the AddPythonSetupITKTagUpdateScript branch March 28, 2019 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Python wrapping Python bindings for a class type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants