Skip to content

ENH: Add a script to update the ITK tag in Azure Pipelines CI config …#634

Closed
jhlegarreta wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
jhlegarreta:AddAzurePipelinesITKTagUpdateScript
Closed

ENH: Add a script to update the ITK tag in Azure Pipelines CI config …#634
jhlegarreta wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
jhlegarreta:AddAzurePipelinesITKTagUpdateScript

Conversation

@jhlegarreta
Copy link
Copy Markdown
Member

@jhlegarreta jhlegarreta commented Mar 25, 2019

…files

Add a script to update the ITK tag in Azure Pipelines CI config files.

@jhlegarreta
ENH: Add a script to update the ITK tag in Azure Pipelines CI config …
4233f07 
…files

Add a script to update the ITK tag in Azure Pipelines CI config files.
@jhlegarreta jhlegarreta added type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Enhancement Improvement of existing methods or implementation labels Mar 25, 2019
@jhlegarreta
Copy link
Copy Markdown
Member Author

jhlegarreta commented Mar 25, 2019

A few comments:

  • This will surely need further testing.
  • jq must be available.
  • We may need to ask for the username so that the user is authenticated in the curl command. I think there is a limit in the anonymous gets.
  • I guess generating a branch and automatically committing/pushing as @hjmjohnson has done in some scripts is also doable, but this is a first version.

thewtex
thewtex reviewed Mar 26, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost always I think we will want to run this along with the setup.py update at the same time -- they could be combined.

@jhlegarreta
Copy link
Copy Markdown
Member Author

jhlegarreta commented Mar 28, 2019

Superseded by #641 to address @thewtex 's comment more cleanly.
Closing this PR.

@jhlegarreta jhlegarreta deleted the AddAzurePipelinesITKTagUpdateScript branch March 28, 2019 00:26
@jhlegarreta jhlegarreta mentioned this pull request Mar 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thewtex thewtex thewtex left review comments

@hjmjohnson hjmjohnson Awaiting requested review from hjmjohnson

@dzenanz dzenanz Awaiting requested review from dzenanz

@blowekamp blowekamp Awaiting requested review from blowekamp

@phcerdan phcerdan Awaiting requested review from phcerdan

@fbudin69500 fbudin69500 Awaiting requested review from fbudin69500

Assignees

No one assigned

Labels

type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jhlegarreta @thewtex