BUG: Update and enable ITKv3 Examples#814
Closed
blowekamp wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
Closed
BUG: Update and enable ITKv3 Examples#814blowekamp wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
blowekamp wants to merge 1 commit intoInsightSoftwareConsortium:masterfrom
Conversation
1 task
hjmjohnson
requested changes
May 3, 2019
Member
hjmjohnson
left a comment
hjmjohnson
left a comment
There was a problem hiding this comment.
@blowekamp I've reviewed this PR, and it is now a proper subset of the work done in #813.
There were a few things that were missed initially. I've restored all the non-duplicated examples and moved the RegistrationITKv3 examples to ITK/Modules/Registration/Common/test/RegistrationITKv3.
I think this PR can be closed with committing. Thanks for the review.
| add_executable(ITKv3ImageRegistration11 ImageRegistration11.cxx ) | ||
| target_link_libraries(ITKv3ImageRegistration11 ${ITK_LIBRARIES}) | ||
|
|
||
| # This example in getting stuck and timing out, likely due to spatial |
| add_subdirectory(Statistics) | ||
| add_subdirectory(RegistrationITKv4) | ||
|
|
||
| if(ITKV3_COMPATIBILITY) |
| add_executable(ITKv3MultiResImageRegistration3 MultiResImageRegistration3.cxx ) | ||
| target_link_libraries(ITKv3MultiResImageRegistration3 ${ITK_LIBRARIES}) | ||
|
|
||
| if (ITKFEMRegistration_ENABLED) |
Member
There was a problem hiding this comment.
This is not necessary. These are 100% redundant with ITKv4 registration examples.
| #include "itkImageFileReader.h" | ||
| #include "itkImageFileWriter.h" | ||
|
|
||
| #include "itkDeformationFieldJacobianDeterminantFilter.h" |
| using OutputPixelType = HistogramToEntropyImageFilterType::OutputPixelType; | ||
|
|
||
| HistogramWriter(): | ||
| m_Metric(0) |
Member
There was a problem hiding this comment.
Duplicate of ITKv4 example. Not needed here.
Member
Author
|
dup of #813. |
hjmjohnson
added a commit
to hjmjohnson/ITK
that referenced
this pull request
Apr 27, 2026
Make the MGHIO module a shared library like the other IO modules. ctest -R MGH 1/14 Test InsightSoftwareConsortium#810: ITKIOMGHInDoxygenGroup ........... Passed 0.05 sec 2/14 Test InsightSoftwareConsortium#811: MGHFactoryCreationTest ........... Passed 0.09 sec 3/14 Test InsightSoftwareConsortium#812: MGHReadImagesTest_mgz ............ Passed 4.23 sec 4/14 Test InsightSoftwareConsortium#813: MGHReadImagesTest_mgh ............ Passed 0.68 sec 5/14 Test InsightSoftwareConsortium#814: MGHReadImagesTest_mgh.gz ......... Passed 4.11 sec 6/14 Test InsightSoftwareConsortium#815: itkITKIOMGHInternalTests ......... Passed 0.08 sec 7/14 Test InsightSoftwareConsortium#816: itkITKIOMGHOriginTest ............ Passed 4.16 sec 8/14 Test InsightSoftwareConsortium#2356: MGHIOInDoxygenGroup .............. Passed 0.04 sec 9/14 Test InsightSoftwareConsortium#2357: MGHFactoryCreationTest ........... Passed 0.07 sec 10/14 Test InsightSoftwareConsortium#2358: MGHReadImagesTest_mgz ............ Passed 4.23 sec 11/14 Test InsightSoftwareConsortium#2359: MGHReadImagesTest_mgh ............ Passed 0.68 sec 12/14 Test InsightSoftwareConsortium#2360: MGHReadImagesTest_mgh.gz ......... Passed 4.13 sec 13/14 Test InsightSoftwareConsortium#2361: itkMGHIOInternalTests ............ Passed 0.07 sec 14/14 Test InsightSoftwareConsortium#2362: itkMGHIOOriginTest ............... Passed 4.13 sec 100% tests passed, 0 tests failed out of 14
hjmjohnson
added a commit
to hjmjohnson/ITK
that referenced
this pull request
Apr 27, 2026
Make the MGHIO module a shared library like the other IO modules. ctest -R MGH 1/14 Test InsightSoftwareConsortium#810: ITKIOMGHInDoxygenGroup ........... Passed 0.05 sec 2/14 Test InsightSoftwareConsortium#811: MGHFactoryCreationTest ........... Passed 0.09 sec 3/14 Test InsightSoftwareConsortium#812: MGHReadImagesTest_mgz ............ Passed 4.23 sec 4/14 Test InsightSoftwareConsortium#813: MGHReadImagesTest_mgh ............ Passed 0.68 sec 5/14 Test InsightSoftwareConsortium#814: MGHReadImagesTest_mgh.gz ......... Passed 4.11 sec 6/14 Test InsightSoftwareConsortium#815: itkITKIOMGHInternalTests ......... Passed 0.08 sec 7/14 Test InsightSoftwareConsortium#816: itkITKIOMGHOriginTest ............ Passed 4.16 sec 8/14 Test InsightSoftwareConsortium#2356: MGHIOInDoxygenGroup .............. Passed 0.04 sec 9/14 Test InsightSoftwareConsortium#2357: MGHFactoryCreationTest ........... Passed 0.07 sec 10/14 Test InsightSoftwareConsortium#2358: MGHReadImagesTest_mgz ............ Passed 4.23 sec 11/14 Test InsightSoftwareConsortium#2359: MGHReadImagesTest_mgh ............ Passed 0.68 sec 12/14 Test InsightSoftwareConsortium#2360: MGHReadImagesTest_mgh.gz ......... Passed 4.13 sec 13/14 Test InsightSoftwareConsortium#2361: itkMGHIOInternalTests ............ Passed 0.07 sec 14/14 Test InsightSoftwareConsortium#2362: itkMGHIOOriginTest ............... Passed 4.13 sec 100% tests passed, 0 tests failed out of 14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Refer to the ITK Software Guide for
further development details if necessary.