Skip to content

WIP: Improve python error message if image file doesnt exist#815

Closed
fbudin69500 wants to merge 1 commit intoInsightSoftwareConsortium:python-buildsfrom
fbudin69500:improve_python_error_message_if_image_file_doesnt_exist
Closed

WIP: Improve python error message if image file doesnt exist#815
fbudin69500 wants to merge 1 commit intoInsightSoftwareConsortium:python-buildsfrom
fbudin69500:improve_python_error_message_if_image_file_doesnt_exist

Conversation

@fbudin69500
Copy link
Copy Markdown
Contributor

… exist

When opening an image file in Python through the itkTemplate class (i.e.
itk.ImageFileReader.New(FileName="my_file.png"), the error message
warns the user that the file does not exist. The error message matches
the error message printed in C++ or when using directly the ImageFileReader
class (i.e. itk.ImageFileReader[ImageType].New(FileName="my_file.png")).

@fbudin69500 fbudin69500 requested a review from thewtex May 3, 2019 15:37
… exist

When opening an image file in Python through the `itkTemplate` class (i.e.
`itk.ImageFileReader.New(FileName="my_file.png")`, the error message
warns the user that the file does not exist. The error message matches
the error message printed in C++ or when using directly the `ImageFileReader`
class (i.e. `itk.ImageFileReader[ImageType].New(FileName="my_file.png")`).
@fbudin69500 fbudin69500 force-pushed the improve_python_error_message_if_image_file_doesnt_exist branch from 73c6182 to 9f65342 Compare May 6, 2019 12:38
Copy link
Copy Markdown
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: need to merge to master instead of python-builds.

@thewtex
Copy link
Copy Markdown
Member

thewtex commented May 18, 2019

Merged to master in #910

@thewtex thewtex closed this May 18, 2019
hjmjohnson added a commit to hjmjohnson/ITK that referenced this pull request Apr 27, 2026
Make the MGHIO module a shared library like the
other IO modules.

ctest -R MGH
 1/14 Test InsightSoftwareConsortium#810: ITKIOMGHInDoxygenGroup ...........   Passed    0.05 sec
 2/14 Test InsightSoftwareConsortium#811: MGHFactoryCreationTest ...........   Passed    0.09 sec
 3/14 Test InsightSoftwareConsortium#812: MGHReadImagesTest_mgz ............   Passed    4.23 sec
 4/14 Test InsightSoftwareConsortium#813: MGHReadImagesTest_mgh ............   Passed    0.68 sec
 5/14 Test InsightSoftwareConsortium#814: MGHReadImagesTest_mgh.gz .........   Passed    4.11 sec
 6/14 Test InsightSoftwareConsortium#815: itkITKIOMGHInternalTests .........   Passed    0.08 sec
 7/14 Test InsightSoftwareConsortium#816: itkITKIOMGHOriginTest ............   Passed    4.16 sec
 8/14 Test InsightSoftwareConsortium#2356: MGHIOInDoxygenGroup ..............   Passed    0.04 sec
 9/14 Test InsightSoftwareConsortium#2357: MGHFactoryCreationTest ...........   Passed    0.07 sec
10/14 Test InsightSoftwareConsortium#2358: MGHReadImagesTest_mgz ............   Passed    4.23 sec
11/14 Test InsightSoftwareConsortium#2359: MGHReadImagesTest_mgh ............   Passed    0.68 sec
12/14 Test InsightSoftwareConsortium#2360: MGHReadImagesTest_mgh.gz .........   Passed    4.13 sec
13/14 Test InsightSoftwareConsortium#2361: itkMGHIOInternalTests ............   Passed    0.07 sec
14/14 Test InsightSoftwareConsortium#2362: itkMGHIOOriginTest ...............   Passed    4.13 sec
100% tests passed, 0 tests failed out of 14
hjmjohnson added a commit to hjmjohnson/ITK that referenced this pull request Apr 27, 2026
Make the MGHIO module a shared library like the
other IO modules.

ctest -R MGH
 1/14 Test InsightSoftwareConsortium#810: ITKIOMGHInDoxygenGroup ...........   Passed    0.05 sec
 2/14 Test InsightSoftwareConsortium#811: MGHFactoryCreationTest ...........   Passed    0.09 sec
 3/14 Test InsightSoftwareConsortium#812: MGHReadImagesTest_mgz ............   Passed    4.23 sec
 4/14 Test InsightSoftwareConsortium#813: MGHReadImagesTest_mgh ............   Passed    0.68 sec
 5/14 Test InsightSoftwareConsortium#814: MGHReadImagesTest_mgh.gz .........   Passed    4.11 sec
 6/14 Test InsightSoftwareConsortium#815: itkITKIOMGHInternalTests .........   Passed    0.08 sec
 7/14 Test InsightSoftwareConsortium#816: itkITKIOMGHOriginTest ............   Passed    4.16 sec
 8/14 Test InsightSoftwareConsortium#2356: MGHIOInDoxygenGroup ..............   Passed    0.04 sec
 9/14 Test InsightSoftwareConsortium#2357: MGHFactoryCreationTest ...........   Passed    0.07 sec
10/14 Test InsightSoftwareConsortium#2358: MGHReadImagesTest_mgz ............   Passed    4.23 sec
11/14 Test InsightSoftwareConsortium#2359: MGHReadImagesTest_mgh ............   Passed    0.68 sec
12/14 Test InsightSoftwareConsortium#2360: MGHReadImagesTest_mgh.gz .........   Passed    4.13 sec
13/14 Test InsightSoftwareConsortium#2361: itkMGHIOInternalTests ............   Passed    0.07 sec
14/14 Test InsightSoftwareConsortium#2362: itkMGHIOOriginTest ...............   Passed    4.13 sec
100% tests passed, 0 tests failed out of 14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants