Skip to content

cardano-rpc | Move AddressArray proto definition to cardano.proto#945

Merged
carbolymer merged 1 commit intomasterfrom
mgalazyn/feature/rpc-move-address-array-to-cardano-proto
Sep 10, 2025
Merged

cardano-rpc | Move AddressArray proto definition to cardano.proto#945
carbolymer merged 1 commit intomasterfrom
mgalazyn/feature/rpc-move-address-array-to-cardano-proto

Conversation

@carbolymer
Copy link
Copy Markdown
Contributor

@carbolymer carbolymer commented Sep 5, 2025 •
edited by palas
Loading

Changelog

- description: |
    cardano-rpc | Move `AddressArray` proto definition to cardano.proto
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
   - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...
  projects:
  - cardano-rpc

Context

Upstream PR:

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer self-assigned this Sep 5, 2025
@carbolymer carbolymer force-pushed the mgalazyn/feature/rpc-move-address-array-to-cardano-proto branch from 5c57db5 to f857964 Compare September 5, 2025 16:19
@carbolymer carbolymer marked this pull request as ready for review September 5, 2025 16:20
palas
palas approved these changes Sep 8, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@palas palas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and it matches the PRs in the comments

@carbolymer carbolymer enabled auto-merge September 9, 2025 11:39
@carbolymer carbolymer force-pushed the mgalazyn/feature/rpc-move-address-array-to-cardano-proto branch from f857964 to a345801 Compare September 9, 2025 11:39
@carbolymer carbolymer added this pull request to the merge queue Sep 9, 2025
github-merge-queue Bot pushed a commit that referenced this pull request Sep 9, 2025
@carbolymer
Merge pull request #945 from IntersectMBO/mgalazyn/feature/rpc-move-a…
650aceb 
…ddress-array-to-cardano-proto

cardano-rpc | Move AddressArray proto definition to cardano.proto
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Sep 9, 2025
@carbolymer carbolymer added this pull request to the merge queue Sep 10, 2025
Merged via the queue into master with commit b2e7e53 Sep 10, 2025
29 checks passed
@carbolymer carbolymer deleted the mgalazyn/feature/rpc-move-address-array-to-cardano-proto branch September 10, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@palas palas palas approved these changes

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd erikd is a code owner

@newhoggy newhoggy Awaiting requested review from newhoggy

@kevinhammond kevinhammond Awaiting requested review from kevinhammond

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara CarlosLopezDeLara is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees

@carbolymer carbolymer

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@carbolymer @palas @Jimbo4350