feat(cardano): allow reading of UTXOs by an address#167
Closed
carbolymer wants to merge 1 commit intoutxorpc:mainfrom
Closed
feat(cardano): allow reading of UTXOs by an address#167carbolymer wants to merge 1 commit intoutxorpc:mainfrom
carbolymer wants to merge 1 commit intoutxorpc:mainfrom
Conversation
c6c2657 to
efe5773
Compare
Merged
3 tasks
Member
|
@carbolymer the idea of the In contrast, the We decided to split it in this way since there are several optimizations (caching, batch loading, etc) that can be performed only when doing a key-value retrieval. Do you think that the |
Member
|
as discussed in the bi-weekly, the guideline for this use-case is to use the search utxos endpoints. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In cardano we are able to query UTXOs by TxIn (
txoRefin u5c) or by an address. This PR adds capability of querying by addresses to proto definition.There's also an open question:
What should a server implementation do when an empty list of tx output references or addresses is provided? Should a recommendation for that case be placed in the comments?
It would be convenient to just return a whole UTXO set for that case, which would be very useful for testing.