Skip to content

feat(#2243): add epochParams and ada holder balance to Proposal pillar#3424

Merged
MSzalowski merged 1 commit into
developfrom
feat/2243-insufficient-balance-check-should-be-earlier-in-ga-submission
Apr 9, 2025
Merged

feat(#2243): add epochParams and ada holder balance to Proposal pillar#3424
MSzalowski merged 1 commit into
developfrom
feat/2243-insufficient-balance-check-should-be-earlier-in-ga-submission

Conversation

@MSzalowski
Copy link
Copy Markdown
Contributor

List of changes

  • add epochParams and ada holder balance to Proposal pillar

New properties passed to PDF:

          <ProposalDiscussion
            pdfApiUrl={import.meta.env.VITE_PDF_API_URL}
            walletAPI={{
              ...context,
              ...walletApi,
              createGovernanceActionJsonLD,
              createHash,
              voter,
            }}
            pathname={window.location.pathname}
            validateMetadata={
              validateMetadata as ComponentProps<
                typeof ProposalDiscussion
              >["validateMetadata"]
            }
            fetchDRepVotingPowerList={fetchDRepVotingPowerList}
            // New properties passed
            epochParams={epochParams}
            votingPower={votingPower}
          />

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2025

✅ All checks succeeded

@MSzalowski MSzalowski force-pushed the feat/2243-insufficient-balance-check-should-be-earlier-in-ga-submission branch from c96838f to 3bba435 Compare April 9, 2025 07:53
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2025

✅ All checks succeeded

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2025

✅ All checks succeeded

@MSzalowski MSzalowski force-pushed the feat/2243-insufficient-balance-check-should-be-earlier-in-ga-submission branch from 3bba435 to d9cbd2a Compare April 9, 2025 10:26
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2025

✅ All checks succeeded

@MSzalowski MSzalowski merged commit 87ce23c into develop Apr 9, 2025
8 checks passed
@MSzalowski MSzalowski deleted the feat/2243-insufficient-balance-check-should-be-earlier-in-ga-submission branch April 9, 2025 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Insufficient balance check should be earlier in GA submission

2 participants