Skip to content

feat(#3622): home page redesign#3642

Merged
MSzalowski merged 1 commit into
developfrom
feat/3622-updated-dashboard-with-all-inclusive-features
May 22, 2025
Merged

feat(#3622): home page redesign#3642
MSzalowski merged 1 commit into
developfrom
feat/3622-updated-dashboard-with-all-inclusive-features

Conversation

@MSzalowski
Copy link
Copy Markdown
Contributor

@MSzalowski MSzalowski commented May 16, 2025 •
edited
Loading

List of changes

  • home page redesign

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski requested a review from Ryun1 as a code owner May 16, 2025 12:12
@MSzalowski MSzalowski linked an issue May 16, 2025 that may be closed by this pull request
Updated Dashboard with all-inclusive features #3622
Open
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 16, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 16, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 16, 2025

✅ All checks succeeded

@MSzalowski MSzalowski requested a review from Ciabas May 19, 2025 09:39
@MSzalowski MSzalowski force-pushed the feat/3622-updated-dashboard-with-all-inclusive-features branch from 78688cf to 5c2030e Compare May 19, 2025 11:54
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2025

✅ All checks succeeded

@MSzalowski MSzalowski force-pushed the feat/3622-updated-dashboard-with-all-inclusive-features branch from 5c2030e to afa55cc Compare May 19, 2025 16:13
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 19, 2025

✅ All checks succeeded

@MSzalowski MSzalowski force-pushed the feat/3622-updated-dashboard-with-all-inclusive-features branch from afa55cc to db35c87 Compare May 21, 2025 20:34
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2025

✅ All checks succeeded

@MSzalowski MSzalowski force-pushed the feat/3622-updated-dashboard-with-all-inclusive-features branch from db35c87 to 85398a8 Compare May 21, 2025 21:38
@MSzalowski MSzalowski changed the title WIP: feat(#3622): home page redesign feat(#3622): home page redesign May 21, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 21, 2025

✅ All checks succeeded

Ciabas
Ciabas reviewed May 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Ciabas Ciabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, I just have a few comments to make it more accessible.

Comment thread govtool/frontend/src/components/molecules/HomeCard.tsx
Comment thread govtool/frontend/src/components/molecules/HomeCard.tsx Outdated
Comment thread govtool/frontend/src/components/molecules/HomeCard.tsx
Comment thread govtool/frontend/src/components/organisms/Home/UsefulLinks.tsx Outdated
Comment thread govtool/frontend/src/components/organisms/Home/Socials.tsx Outdated
Comment thread govtool/frontend/src/pages/Home.tsx
Ciabas
Ciabas reviewed May 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Ciabas Ciabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW it's it weird that we introduce two components with the same behaviour, with different appearances?

Both are directing to an external source, but one have onClick and the other hyperlink in it.

image
image

Ciabas
Ciabas reviewed May 22, 2025
View reviewed changes
Comment thread govtool/frontend/src/components/organisms/Home/UsefulLinks.tsx
@MSzalowski MSzalowski force-pushed the feat/3622-updated-dashboard-with-all-inclusive-features branch from 85398a8 to 984208f Compare May 22, 2025 12:06
@MSzalowski
Copy link
Copy Markdown
Contributor Author

MSzalowski commented May 22, 2025

@Ciabas Could you review once again my changes?

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2025

✅ All checks succeeded

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2025

✅ All checks succeeded

@MSzalowski MSzalowski force-pushed the feat/3622-updated-dashboard-with-all-inclusive-features branch from 984208f to 95edffc Compare May 22, 2025 12:37
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2025

✅ All checks succeeded

@MSzalowski MSzalowski force-pushed the feat/3622-updated-dashboard-with-all-inclusive-features branch from 95edffc to 8aad26a Compare May 22, 2025 12:48
@MSzalowski MSzalowski force-pushed the feat/3622-updated-dashboard-with-all-inclusive-features branch from 8aad26a to 60721e2 Compare May 22, 2025 12:49
Ciabas
Ciabas approved these changes May 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Ciabas Ciabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. Thanks for addressing my comments.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 22, 2025

✅ All checks succeeded

@MSzalowski MSzalowski merged commit 22fe269 into develop May 22, 2025
8 checks passed
@MSzalowski MSzalowski deleted the feat/3622-updated-dashboard-with-all-inclusive-features branch May 22, 2025 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

1 more reviewer

@Ciabas Ciabas Ciabas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Updated Dashboard with all-inclusive features

2 participants

@MSzalowski @Ciabas