Skip to content

fix(#3622): apply new design system theme changes to home page#3675

Merged
MSzalowski merged 2 commits into
developfrom
fix/3622-layout-updates
May 23, 2025
Merged

fix(#3622): apply new design system theme changes to home page#3675
MSzalowski merged 2 commits into
developfrom
fix/3622-layout-updates

Conversation

@MSzalowski
Copy link
Copy Markdown
Contributor

List of changes

Nagranie.z.ekranu.2025-05-23.o.13.19.29.mov

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski linked an issue May 23, 2025 that may be closed by this pull request
@MSzalowski MSzalowski requested a review from m-i-k-e May 23, 2025 11:21
@MSzalowski
Copy link
Copy Markdown
Contributor Author

@m-i-k-e Please have a look on the changes. Also I haven't applied any update to the link behavious as I am waiting for the response on slack

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@MSzalowski MSzalowski requested a review from Ciabas May 23, 2025 12:15
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

Copy link
Copy Markdown
Contributor

@Ciabas Ciabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to use variant title or title1 instead of creating a new one titleH3.

@MSzalowski MSzalowski merged commit 74c6824 into develop May 23, 2025
8 checks passed
@MSzalowski MSzalowski deleted the fix/3622-layout-updates branch May 23, 2025 12:54
@github-actions
Copy link
Copy Markdown
Contributor

@MSzalowski
This PR is in the tag: develop-74c682447d5ebd5643b975ed6750c343d41cc766 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

@MSzalowski
This PR is in the tag: develop-74c682447d5ebd5643b975ed6750c343d41cc766 , for govtool-backend service

@github-actions
Copy link
Copy Markdown
Contributor

@MSzalowski
This PR is in the tag: develop-74c682447d5ebd5643b975ed6750c343d41cc766 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

@MSzalowski
This PR is in the tag: develop-74c682447d5ebd5643b975ed6750c343d41cc766 , for govtool-backend service

@github-actions
Copy link
Copy Markdown
Contributor

@MSzalowski
This PR is in the tag: develop-74c682447d5ebd5643b975ed6750c343d41cc766 , for govtool-frontend service

@m-i-k-e
Copy link
Copy Markdown

m-i-k-e commented May 28, 2025

@MSzalowski This is not on preview. Do you want me to check it on dev? I need a link.

@Ciabas
Copy link
Copy Markdown
Contributor

Ciabas commented May 28, 2025

It is not. We have reverted the main dashboard as requested.

@m-i-k-e
Copy link
Copy Markdown

m-i-k-e commented May 30, 2025

@Ciabas

We have reverted the main dashboard as requested.

Can you please clarify?

@bosko-m
Copy link
Copy Markdown
Contributor

bosko-m commented May 30, 2025

@m-i-k-e We arent proceeding with these changes at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updated Dashboard with all-inclusive features

4 participants