fix(#3714): type error on linkReferences when editing dRep page#3717
Merged
bosko-m merged 1 commit intoJun 3, 2025
Conversation
Contributor
|
✅ All checks succeeded |
1 similar comment
Contributor
|
✅ All checks succeeded |
Contributor
|
✅ All checks succeeded |
3 similar comments
Contributor
|
✅ All checks succeeded |
Contributor
|
✅ All checks succeeded |
Contributor
|
✅ All checks succeeded |
Ciabas
force-pushed
the
3714-blank-screen-and-type-error-on-linkreferences-when-navigating-to-edit-drep-page
branch
from
5800bb2 to
50f7802
Compare
Ciabas
commented
Jun 3, 2025
| image: data?.image ?? "", | ||
| linkReferences: data.linkReferences ?? [getEmptyReference("Link")], | ||
| identityReferences: data.identityReferences ?? [ | ||
| linkReferences: data?.linkReferences ?? [getEmptyReference("Link")], |
Contributor
Author
There was a problem hiding this comment.
Previously there was an optional chaining operator, which we missed.
Contributor
|
✅ All checks succeeded |
2 similar comments
Contributor
|
✅ All checks succeeded |
Contributor
|
✅ All checks succeeded |
Ciabas
force-pushed
the
3714-blank-screen-and-type-error-on-linkreferences-when-navigating-to-edit-drep-page
branch
from
50f7802 to
15c62a7
Compare
Contributor
|
✅ All checks succeeded |
2 similar comments
Contributor
|
✅ All checks succeeded |
Contributor
|
✅ All checks succeeded |
bosko-m
approved these changes
Jun 3, 2025
bosko-m
deleted the
3714-blank-screen-and-type-error-on-linkreferences-when-navigating-to-edit-drep-page
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of changes
Checklist