Skip to content

fix(#3714): type error on linkReferences when editing dRep page #3717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bosko-m merged 1 commit into from
Jun 3, 2025
Merged

fix(#3714): type error on linkReferences when editing dRep page #3717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ changes.
### Fixed

- Fix missing off chain references in DRep details [Issue 3490](https://github.com/IntersectMBO/govtool/issues/3490)
- Fix blank screen and type error on linkReferences when navigating to edit dRep page that has no links [Issue 3714](https://github.com/IntersectMBO/govtool/issues/3714)

### Changed

Expand Down
4 changes: 2 additions & 2 deletions govtool/frontend/src/components/organisms/EditDRepInfoSteps/EditDRepForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ export const EditDRepForm = ({
qualifications: data?.qualifications ?? "",
paymentAddress: data?.paymentAddress ?? "",
image: data?.image ?? "",
linkReferences: data.linkReferences ?? [getEmptyReference("Link")],
identityReferences: data.identityReferences ?? [
linkReferences: data?.linkReferences ?? [getEmptyReference("Link")],
Copy link
Copy Markdown
Contributor Author

@Ciabas Ciabas Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously there was an optional chaining operator, which we missed.
image

identityReferences: data?.identityReferences ?? [
getEmptyReference("Identity"),
],
});
Expand Down