Skip to content

(fix#3142): Fix missing page titles on subpages: DRep details and Gov Actions details#3861

Merged
Ciabas merged 1 commit into
developfrom
3142-missing-page-title-drep-directory
Jul 1, 2025
Merged

(fix#3142): Fix missing page titles on subpages: DRep details and Gov Actions details#3861
Ciabas merged 1 commit into
developfrom
3142-missing-page-title-drep-directory

Conversation

@Ciabas
Copy link
Copy Markdown
Contributor

@Ciabas Ciabas commented Jul 1, 2025

List of changes

  • Fix missing page titles on subpages: DRep details and Gov Actions details

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

Changes

image
image

@Ciabas Ciabas requested a review from bosko-m July 1, 2025 08:06
@Ciabas Ciabas self-assigned this Jul 1, 2025
@Ciabas Ciabas requested review from MSzalowski and Ryun1 as code owners July 1, 2025 08:06
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 1, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 1, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 1, 2025

✅ All checks succeeded

(result, item) =>
result ??
(targetPath === item.navTo
(targetPath === item.navTo || targetPath.startsWith(`${item.navTo}/`)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ciabas Title of the page should actually be Live Voting (actual page) and not Governance Actions (parent page).
DRep details stays the same

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3132
Do we want to fix it here or as another pull request connected to the #3132?

@Ciabas Ciabas requested a review from bosko-m July 1, 2025 10:27
@Ciabas Ciabas merged commit 783551c into develop Jul 1, 2025
8 checks passed
@Ciabas Ciabas deleted the 3142-missing-page-title-drep-directory branch July 1, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants