Skip to content

(fix#3142): Fix missing page titles on subpages: DRep details and Gov Actions details #3861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ciabas merged 1 commit into from
Jul 1, 2025
Merged

(fix#3142): Fix missing page titles on subpages: DRep details and Gov Actions details #3861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ changes.
- Fix blank screen and type error on linkReferences when navigating to edit dRep page that has no links [Issue 3714](https://github.com/IntersectMBO/govtool/issues/3714)
- Fix adding two link input fields when editing the dRep form when no links are present initially [Issue 3709](https://github.com/IntersectMBO/govtool/issues/3709)
- Fix images in Governance Action Details are displayed at full width and height without cropping or clipping [Issue 3837](https://github.com/IntersectMBO/govtool/issues/3837)
- Fix missing page titles on subpages: DRep details and Gov Actions details [Issue 3142](https://github.com/IntersectMBO/govtool/issues/3142)

### Changed
- Adjust top menu (navbar) layout when wallet is not connected [Issue-3682](https://github.com/IntersectMBO/govtool/issues/3682)
Expand Down
2 changes: 1 addition & 1 deletion govtool/frontend/src/pages/Dashboard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ export const Dashboard = () => {
items.reduce<string | null>(
(result, item) =>
result ??
(targetPath === item.navTo
(targetPath === item.navTo || targetPath.startsWith(`${item.navTo}/`)
Copy link
Copy Markdown
Contributor

@bosko-m bosko-m Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ciabas Title of the page should actually be Live Voting (actual page) and not Governance Actions (parent page).
DRep details stays the same

Copy link
Copy Markdown
Contributor Author

@Ciabas Ciabas Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3132
Do we want to fix it here or as another pull request connected to the #3132?

? item.label
: item.childNavItems
? findNavItem(item.childNavItems, targetPath)
Expand Down