Skip to content

(fix#3879): broken parameters on Live Voting page#3883

Merged
Ciabas merged 1 commit into
developfrom
3879-parameters-page-on-live-voting-broken-p0
Jul 11, 2025
Merged

(fix#3879): broken parameters on Live Voting page#3883
Ciabas merged 1 commit into
developfrom
3879-parameters-page-on-live-voting-broken-p0

Conversation

@Ciabas
Copy link
Copy Markdown
Contributor

@Ciabas Ciabas commented Jul 9, 2025

List of changes

  • Fix broken parameters on Live Voting page when membersToBeRemoved contained odd values

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

Explanation

The problem was having a null value in membersToBeRemoved, where we expect to have an array of strings:
image

Now even with such values, the site works:
image

@Ciabas Ciabas requested a review from aaboyle878 July 9, 2025 12:11
@Ciabas Ciabas self-assigned this Jul 9, 2025
@Ciabas Ciabas requested a review from MSzalowski as a code owner July 9, 2025 12:11
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 9, 2025

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 9, 2025

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 9, 2025

✅ All checks succeeded

@Ciabas Ciabas merged commit 1097c02 into develop Jul 11, 2025
8 checks passed
@Ciabas Ciabas deleted the 3879-parameters-page-on-live-voting-broken-p0 branch July 11, 2025 14:09
@github-actions
Copy link
Copy Markdown
Contributor

@Ciabas
This PR is in the tag: develop-1097c02eb8697c9aed80cd48610935c144a4300f , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

@Ciabas
This PR is in the tag: develop-1097c02eb8697c9aed80cd48610935c144a4300f , for govtool-backend service

@github-actions
Copy link
Copy Markdown
Contributor

@Ciabas
This PR is in the tag: develop-1097c02eb8697c9aed80cd48610935c144a4300f , for govtool-frontend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants