Skip to content

(fix#3879): broken parameters on Live Voting page #3883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ciabas merged 1 commit into from
Jul 11, 2025
Merged

(fix#3879): broken parameters on Live Voting page #3883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions govtool/frontend/src/components/molecules/GovernanceActionNewCommitteeDetailsTabContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,12 @@ type CCMember = {
newExpirationEpoch?: number;
};

function isArrayOfStrings(value: unknown): value is string[] {
return (
Array.isArray(value) && value.every((item) => typeof item === "string")
);
}

export const GovernanceActionNewCommitteeDetailsTabContent = ({
details,
}: Pick<ProposalData, "details">) => {
Expand All @@ -38,6 +44,10 @@ export const GovernanceActionNewCommitteeDetailsTabContent = ({
newExpirationEpoch: member.newExpirationEpoch,
}));

const membersToBeRemoved = isArrayOfStrings(details?.membersToBeRemoved)
? details.membersToBeRemoved
: [];

return (
<Box>
{membersToBeAdded.length > 0 && (
Expand Down Expand Up @@ -78,7 +88,7 @@ export const GovernanceActionNewCommitteeDetailsTabContent = ({
))}
</Box>
)}
{(details?.membersToBeRemoved as string[]).length > 0 && (
{membersToBeRemoved.length > 0 && (
<Box mb="32px">
<Typography
sx={{
Expand All @@ -93,8 +103,8 @@ export const GovernanceActionNewCommitteeDetailsTabContent = ({
>
{t("govActions.membersToBeRemoved")}
</Typography>
{(details?.membersToBeRemoved as string[]).map((hash) => (
<Box display="flex" flexDirection="row">
{membersToBeRemoved.map((hash) => (
<Box display="flex" flexDirection="row" key={hash}>
<Typography
sx={{
fontSize: 16,
Expand Down
1 change: 1 addition & 0 deletions govtool/frontend/src/components/organisms/DrawerMobile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ export const DrawerMobile = ({
<MenuNavItem
closeDrawer={() => setIsDrawerOpen(false)}
navItem={navItem}
key={navItem.label}
/>
);
}
Expand Down