Skip to content

(fix#3881): update how we display SPO votes#3889

Merged
Ciabas merged 2 commits into
developfrom
3881-update-how-we-display-spo-votes
Jul 10, 2025
Merged

(fix#3881): update how we display SPO votes#3889
Ciabas merged 2 commits into
developfrom
3881-update-how-we-display-spo-votes

Conversation

@Ciabas
Copy link
Copy Markdown
Contributor

@Ciabas Ciabas commented Jul 10, 2025

List of changes

  • add 'not voted' stake for SPO's pool
  • fix SPO's pool calculation % based on the whole group (yes/no/abstain/not-voted)

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

Changes

image

@Ciabas Ciabas requested review from aaboyle878 and l-br1 July 10, 2025 10:43
@Ciabas Ciabas self-assigned this Jul 10, 2025
@Ciabas Ciabas requested a review from MSzalowski as a code owner July 10, 2025 10:43
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

1 similar comment
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@Ciabas Ciabas merged commit b8b6687 into develop Jul 10, 2025
8 checks passed
@Ciabas Ciabas deleted the 3881-update-how-we-display-spo-votes branch July 10, 2025 10:58
@github-actions
Copy link
Copy Markdown
Contributor

@Ciabas
This PR is in the tag: develop-b8b6687416f6c556fdf09835940945a402159e80 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

@Ciabas
This PR is in the tag: develop-b8b6687416f6c556fdf09835940945a402159e80 , for govtool-backend service

@github-actions
Copy link
Copy Markdown
Contributor

@Ciabas
This PR is in the tag: develop-b8b6687416f6c556fdf09835940945a402159e80 , for govtool-frontend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants