Skip to content

(fix#3881): update how we display SPO votes #3889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ciabas merged 2 commits into from
Jul 10, 2025
Merged

(fix#3881): update how we display SPO votes #3889

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f72812a
(fix#3881): add not voted to SPOs counting on gov actions
Ciabas Jul 9, 2025
0f4d315
(fix#3881): calculate SPO % based on the whole group (yes/no/abstain/…
Ciabas Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions govtool/frontend/src/components/molecules/VotesSubmitted.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,14 +109,22 @@ export const VotesSubmitted = ({
100 - (dRepYesVotesPercentage ?? 0) - (dRepNoVotesPercentage ?? 0);

const poolYesVotesPercentage =
poolYesVotes + poolNoVotes
? (poolYesVotes / (poolYesVotes + poolNoVotes)) * 100
typeof poolYesVotes === "number" &&
typeof networkTotalStake?.totalStakeControlledBySPOs === "number" &&
networkTotalStake.totalStakeControlledBySPOs > 0
? (poolYesVotes / networkTotalStake.totalStakeControlledBySPOs) * 100
: undefined;
const poolNoVotesPercentage =
typeof poolNoVotes === "number" &&
typeof networkTotalStake?.totalStakeControlledBySPOs === "number" &&
networkTotalStake.totalStakeControlledBySPOs > 0
? (poolNoVotes / networkTotalStake.totalStakeControlledBySPOs) * 100
: undefined;
const poolNotVotedVotes =
typeof networkTotalStake?.totalStakeControlledBySPOs === "number"
? networkTotalStake.totalStakeControlledBySPOs -
(poolYesVotes + poolNoVotes + poolAbstainVotes)
: undefined;
const poolNoVotesPercentage = poolYesVotesPercentage
? 100 - poolYesVotesPercentage
: poolNoVotes
? 100
: undefined;

const ccYesVotesPercentage = noOfCommitteeMembers
? (ccYesVotes / noOfCommitteeMembers) * 100
Expand Down Expand Up @@ -200,6 +208,7 @@ export const VotesSubmitted = ({
noVotes={poolNoVotes}
noVotesPercentage={poolNoVotesPercentage}
abstainVotes={poolAbstainVotes}
notVotedVotes={poolNotVotedVotes}
threshold={
(() => {
const votingThresholdKey = getGovActionVotingThresholdKey({
Expand Down