Skip to content

DRep search improvements #4030#4040

Merged
bosko-m merged 1 commit into
developfrom
issue-4030
Aug 26, 2025
Merged

DRep search improvements #4030#4040
bosko-m merged 1 commit into
developfrom
issue-4030

Conversation

@Ojly
Copy link
Copy Markdown
Contributor

@Ojly Ojly commented Aug 26, 2025

List of changes

  • Search scope: Changed search scope to the DRep name, and both DRep IDs. The hint text in the search box changed to: "Search for a DRep name or ID"
  • Search pagination: Replaced "Show more" button with pagination.
  • Search results number: Added "Found XXX out of a total of YYY".
  • Search input box: Added a little "X" to clear the search query.

Known issues:

  • Pagination doesn't really makes sense for "Random" sorting (eg. any page content would be different each time).
  • After going to DRep details and back search input is cleared (the issue was already present before the changes).
  • After going to DRep details and back page number resets to 1 (it's really the same issue as search input clearing so it should be fixed along with it)
  • Pagination may need some visual changes based on the feedback (it's not one to one with Figma designs).

Checklist

  • DRep search improvements #4030
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@Ojly Ojly requested review from MSzalowski and Ryun1 as code owners August 26, 2025 09:39
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

2 similar comments
@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@github-actions
Copy link
Copy Markdown
Contributor

✅ All checks succeeded

@bosko-m bosko-m merged commit bcf9ac1 into develop Aug 26, 2025
10 checks passed
@bosko-m bosko-m deleted the issue-4030 branch August 26, 2025 16:08
@github-actions
Copy link
Copy Markdown
Contributor

@Ojly
This PR is in the tag: develop-bcf9ac1b0c38b8cabe5c5a0d511b3e292dce5d20 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

@Ojly
This PR is in the tag: develop-bcf9ac1b0c38b8cabe5c5a0d511b3e292dce5d20 , for govtool-backend service

@github-actions
Copy link
Copy Markdown
Contributor

@Ojly
This PR is in the tag: develop-bcf9ac1b0c38b8cabe5c5a0d511b3e292dce5d20 , for govtool-frontend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants