Skip to content

Fix Proposal Visibility Related Tests#4053

Merged
kneerose merged 2 commits into
IntersectMBO:developfrom
JosephRana11:develop
Sep 4, 2025
Merged

Fix Proposal Visibility Related Tests#4053
kneerose merged 2 commits into
IntersectMBO:developfrom
JosephRana11:develop

Conversation

@JosephRana11
Copy link
Copy Markdown
Contributor

@JosephRana11 JosephRana11 commented Sep 3, 2025

List of Changes

Fixed Test Cases

  • 4N: Should accept valid metadata anchor on vote context
  • 4O: Should reject invalid metadata anchor on vote context

These tests were failing because the voting procedure was outdated. Updated the voting flow to fix these failures.
Additionally, updated the vote context validation logic in 5L to reduce test flakiness.

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@kneerose kneerose self-requested a review September 4, 2025 07:24
@JosephRana11
Copy link
Copy Markdown
Contributor Author

@kneerose please review.

Copy link
Copy Markdown
Contributor

@kneerose kneerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kneerose kneerose merged commit c04491a into IntersectMBO:develop Sep 4, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 4, 2025

@JosephRana11
This PR is in the tag: develop-c04491a97362a629ea49cb190e747d5eaadccb46 , for govtool-metadata-validation service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 4, 2025

@JosephRana11
This PR is in the tag: develop-c04491a97362a629ea49cb190e747d5eaadccb46 , for govtool-backend service

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Sep 4, 2025

@JosephRana11
This PR is in the tag: develop-c04491a97362a629ea49cb190e747d5eaadccb46 , for govtool-frontend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants