Skip to content

Fix Proposal Visibility Related Tests #4053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kneerose merged 2 commits into from
Sep 4, 2025
Merged

Fix Proposal Visibility Related Tests #4053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3681b72
fix(vote): update vote flow and validate context metadata; fix tests …
JosephRana11 Sep 3, 2025
e6e6b0b
chore: update vote rationale context validation logic
JosephRana11 Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ...s/govtool-frontend/playwright/tests/4-proposal-visibility/proposalVisibility.dRep.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,14 @@ test.describe("Logged in DRep", () => {
GovernanceActionType.InfoAction
)
: await govActionsPage.viewFirstProposal();

await govActionDetailsPage.yesVoteRadio.click();
await govActionDetailsPage.voteBtn.click()


await govActionDetailsPage.contextInput.fill(faker.lorem.sentence(200));
await govActionDetailsPage.confirmModalBtn.click();
await govActionDetailsPage.downloadAndStoreYourselfOptionBtn.click();
await page.getByRole("checkbox").click();
await govActionDetailsPage.confirmModalBtn.click();
});
Expand Down
9 changes: 4 additions & 5 deletions ...ool-frontend/playwright/tests/5-proposal-functionality/proposalFunctionality.dRep.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,13 +259,12 @@ test.describe("Perform voting", () => {

govActionDetailsPage = await governanceActionsPage.viewFirstVotedProposal();


await govActionDetailsPage.currentPage.getByTestId("yes-radio").isVisible();

await govActionDetailsPage.currentPage.getByTestId("show-more-button").click();
await govActionDetailsPage.currentPage.waitForTimeout(2000);

const voteRationaleContext = await govActionDetailsPage.currentPage.getByTestId("vote-rationale-context");
await expect(voteRationaleContext).toContainText(fakerContext);
const voteRationaleContext = await govActionDetailsPage.currentPage.getByTestId("vote-rationale-context").textContent();

expect(voteRationaleContext).toEqual(fakerContext);
});

test("5I. Should view the vote details,when viewing governance action already voted by the DRep", async ({}, testInfo) => {
Expand Down