Update to Boost version 1.83.0#875
Merged
climbfuji merged 2 commits intoJCSDA:developfrom Nov 17, 2023
srherbener:feature/add-boost-1.83.0
Merged
Update to Boost version 1.83.0#875climbfuji merged 2 commits intoJCSDA:developfrom srherbener:feature/add-boost-1.83.0
climbfuji merged 2 commits intoJCSDA:developfrom
srherbener:feature/add-boost-1.83.0
Conversation
srherbener
requested review from
AlexanderRichert-NOAA,
climbfuji and
ulmononian
This was referenced Nov 16, 2023
Collaborator
|
@srherbener I merged the spack PR, new hash is JCSDA/spack@5cdb7ce |
Contributor
Author
Thanks @climbfuji! I've updated the spack submodule accordingly, and restored the .gitmodules file. |
climbfuji
approved these changes
Nov 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the common/packages.py to use the latest version of Boost (1.83.0) which contains a fix for a narrowing implicit integer conversion error in the boost include file: executor.hpp.
Testing
Describe the testing done for this PR.
Testing building this on my arm64 mac and verified that the fix for the narrowing conversion works.
CI tests passed.
Applications affected
JEDI, UFS, etc.
Systems affected
MacOS and HPC platforms
Dependencies
Issue(s) addressed
Resolves #874
Checklist