Skip to content

Add Boost 1.83.0#367

Merged
climbfuji merged 1 commit intoJCSDA:jcsda_emc_spack_stackfrom
srherbener:feature/add-boost-1.83.0
Nov 17, 2023
Merged

Add Boost 1.83.0#367
climbfuji merged 1 commit intoJCSDA:jcsda_emc_spack_stackfrom
srherbener:feature/add-boost-1.83.0

Conversation

@srherbener
Copy link
Copy Markdown

@srherbener srherbener commented Nov 16, 2023

Description

This PR adds the version statement in the boost package.py script for the latest Boost version: 1.83.0. This change was formed by cherry picking the commit from the authoritative spack repo.

Issue(s) addressed

Partial resolution of JCSDA/spack-stack/issues/874

Dependencies

List the other PRs that this PR is dependent on:
None

Impact

Expected impact on downstream repositories:
This PR needs to be merged before: JCSDA/spack-stack/pull/875

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (N/A)
  • I have run the unit tests before creating the PR

Copy link
Copy Markdown
Collaborator

@climbfuji climbfuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed the style checks failed with a cryptic error message. I am rerunning it, just in case it was a one off. See https://github.com/JCSDA/spack/actions/runs/6894361625/job/18757898415

@climbfuji
Copy link
Copy Markdown
Collaborator

CI is still failing in style checks:

==> Running mypy checks
lib/spack/spack/parser.py:204: error: Item "None" of "Optional[Match[Any]]" has no attribute "lastgroup"  [union-attr]
==> Error: spack style found errors
lib/spack/spack/parser.py:204: note: Error code "union-attr" not covered by "type: ignore" comment
lib/spack/spack/parser.py:204: error: Invalid index type "Union[str, None, Any]" for "MappingProxyType[str, TokenType]"; expected type "str"  [index]
lib/spack/spack/parser.py:204: note: Error code "index" not covered by "type: ignore" comment
lib/spack/spack/parser.py:205: error: Item "None" of "Optional[Match[Any]]" has no attribute "group"  [union-attr]
lib/spack/spack/parser.py:205: note: Error code "union-attr" not covered by "type: ignore" comment
lib/spack/spack/parser.py:206: error: Item "None" of "Optional[Match[Any]]" has no attribute "start"  [union-attr]
lib/spack/spack/parser.py:206: note: Error code "union-attr" not covered by "type: ignore" comment
lib/spack/spack/parser.py:207: error: Item "None" of "Optional[Match[Any]]" has no attribute "end"  [union-attr]
lib/spack/spack/parser.py:207: note: Error code "union-attr" not covered by "type: ignore" comment
Found 5 errors in 1 file (checked 577 source files)
  mypy found errors

@srherbener
Copy link
Copy Markdown
Author

I noticed the style checks failed with a cryptic error message. I am rerunning it, just in case it was a one off. See https://github.com/JCSDA/spack/actions/runs/6894361625/job/18757898415

Strange - the style check appears to be flagging errors in lib/spack/spack/parser.py which of course is not part of this PR. Is this perhaps a change where the lib/spack/spack directory used to be ignored and now is not, or the style checker itself was upgraded and now finds "new" issues?

@climbfuji
Copy link
Copy Markdown
Collaborator

Triggered CI for unmodified spack code (jcsda_emc_spack_stack) in #368 ...

@climbfuji
Copy link
Copy Markdown
Collaborator

style CI also failed for the test PR #368, therefore we can go ahead and merge this.

@climbfuji climbfuji merged commit 5cdb7ce into JCSDA:jcsda_emc_spack_stack Nov 17, 2023
@srherbener srherbener deleted the feature/add-boost-1.83.0 branch November 17, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants