Update ecflow version to 5.11.4 (latest)#881
Merged
climbfuji merged 3 commits intoJCSDA:developfrom Nov 18, 2023
srherbener:bugfix/ecflow-boost-cxx17
Merged
Update ecflow version to 5.11.4 (latest)#881climbfuji merged 3 commits intoJCSDA:developfrom srherbener:bugfix/ecflow-boost-cxx17
climbfuji merged 3 commits intoJCSDA:developfrom
srherbener:bugfix/ecflow-boost-cxx17
Conversation
…sh to bugfix for ecflow and boost compatibility with c++17 build. Updated .gitmodules to point to the corresponding spack bugfix branch.
srherbener
requested review from
AlexanderRichert-NOAA,
climbfuji and
ulmononian
Collaborator
|
@srherbener I merged the spack companion PR, please update this PR. Thanks! |
Contributor
Author
Thanks! This PR is updated now. |
climbfuji
approved these changes
Nov 18, 2023
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
CI passed, the spack PRs were approved in our fork and in spack mainline (also got merged already), so we can merge this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains an update to the ecflow version from 5.8.4 to 5.11.4. This is needed to enable building ecflow on the macOS using the new apple-clang@15.0.0 compilers.
Testing
I have tested this manually on my Mac and verified that ecflow builds successfully. I also verified that using ecflow 5.84 doesn't work, which is why the version bump to 5.11.4 is necessary.
Applications affected
This is only a change to the ecflow version, and my understanding is that JEDI is the only app using ecflow. Please correct me if this is wrong.
Systems affected
macOS and HPC systems
Dependencies
Issue(s) addressed
Resolves #877
Checklist