Ensure proper setting for BOOST_NO_CXX98_FUNCTION_BASE control when building ecflow with C++17#370
Merged
climbfuji merged 4 commits intoJCSDA:jcsda_emc_spack_stackfrom Nov 17, 2023
srherbener:bugfix/ecflow-boost-cxx17
Merged
Ensure proper setting for BOOST_NO_CXX98_FUNCTION_BASE control when building ecflow with C++17#370climbfuji merged 4 commits intoJCSDA:jcsda_emc_spack_stackfrom srherbener:bugfix/ecflow-boost-cxx17
climbfuji merged 4 commits intoJCSDA:jcsda_emc_spack_stackfrom
srherbener:bugfix/ecflow-boost-cxx17
Conversation
… variant that is needed to set BOOST_NO_CXX98_FUNCTION_BASE appropriately when building with C++17 standard.
…dy specifying to use the c++17 standard for newer versions. The use of the BOOST_NO_CXX98_FUNCTION_BASE define is now triggered by the ecflow version.
srherbener
requested review from
AlexanderRichert-NOAA,
climbfuji and
ulmononian
climbfuji
approved these changes
Nov 17, 2023
Collaborator
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Thanks, happy with the changes. Don't see why the spack PR wouldn't go through as it is now. @AlexanderRichert-NOAA can you please review both the spack mainline PR and this one?
4 tasks
AlexanderRichert-NOAA
approved these changes
Nov 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR properly defines BOOST_NO_CXX98_FUNCTION_BASE when building ecflow with the C++17 standard. The ecflow CMake configuration has been setting the C++17 standard since version 5.8.3 (ie, using the
-std=gnu++17compiler option). When using C++17, the boost executor.hpp include file needs to have BOOST_NO_CXX98_FUNCTION_BASE defined to build successfully.I have a PR in the authoritative spack repo (spack#41120) with corresponding updates. The changes in this PR were made by cherry picking the commits from spack#41120.
I've tested these changes on my Mac and verified that building ecflow (5.11.4) works when using apple-clang@15.0.0 compilers.
Issue(s) addressed
Partially resolves JCSDA/spack-stack/issues/877
Dependencies
List the other PRs that this PR is dependent on:
None
Impact
Expected impact on downstream repositories:
None
Checklist