Replace new instantiation of BuildInfo with calls to Injector

[calixtus]

closes https://github.com/JabRef/jabref-issue-melting-pot/issues/604

also removes some telemetry artifacts

Mandatory checks

• Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
• Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

[koppor]

Looks good - you decided against constructor-based injection, but sued the Injector directly? If it is OK for you, it is OK for me!

[calixtus]

I have no hard opinion on this atm. Probably think about some hours. Will come back to this later

[koppor]

I think, constructor-based injection will increase the code, but the dependencies are explicit. In constract, with the injector, one "just" needs to search for class usages with an Injector...

Using the example of BuildInfo can guide us to fix an ADR. -- I mean: Implement with Injector (done here), implement as constructor passing (maybe in another PR) and then compare.

[Siedlerchr]

In general, constructor based dependency injection is preferable because you can better test it and it's more explicit. For example, spring also recommends ctor based injection

[github-actions]

The build of this PR is available at https://builds.jabref.org/pull/11954/merge.

[koppor]

I like keeping the preferences together. - Some code still needs to be adapted to use

importerPreferences.getApiKey(getName())

instead of

Injector.instantiateModelOrService(BuildInfo.class).semanticScholarApiKey

because the keys are now provided by importerPreferences.getApiKey

[InAnYan]

#11954 (comment)

Then what is the purpose of DI framework? Like the one we use?

[calixtus]

Afterburner is not a di framework.
It just provides some basic functionality to provide injections into presenters.
See discussion here: #11342 (comment)

[github-actions]

The build of this PR is available at https://builds.jabref.org/pull/11954/merge.

[github-actions]

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.