Skip to content

Do not use Injector while initializing logging#11969

Merged
koppor merged 1 commit intomainfrom
hotfix-logging
Oct 15, 2024
Merged

Do not use Injector while initializing logging#11969
koppor merged 1 commit intomainfrom
hotfix-logging

Conversation

@koppor
Copy link
Copy Markdown
Member

@koppor koppor commented Oct 15, 2024

Current main:

> Task :run
WARNING: Using incubator modules: jdk.incubator.vector
Messages are not initialized before accessing key: Display help on command line options
Exception in thread "main" java.lang.UnsupportedOperationException: Configuration cannot be changed after applying to tinylog
        at org.tinylog.api@2.7.0/org.tinylog.configuration.Configuration.set(Configuration.java:288)
        at java.base/java.util.Map.forEach(Map.java:733)
        at org.jabref@100.0.0/org.jabref.cli.JabRefCli.initLogging(JabRefCli.java:164)
        at org.jabref@100.0.0/org.jabref.Launcher.main(Launcher.java:26)

This is because of the use of injector (introduced in #11954 - and merged into #11921).

This PR fixes it.


Hotfix, therefore I will merge immediatly.

Mandatory checks

  • I own the copyright of the code submitted and I licence it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@github-actions
Copy link
Copy Markdown
Contributor

The build of this PR is available at https://builds.jabref.org/pull/11969/merge.

@koppor koppor merged commit 88b516f into main Oct 15, 2024
@koppor koppor deleted the hotfix-logging branch October 15, 2024 07:41
@github-actions
Copy link
Copy Markdown
Contributor

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant